chrome/browser/prefs/browser_prefs.h - Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code.

Unified Diff: chrome/browser/prefs/browser_prefs.h

Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gab comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prefs/browser_prefs.h

diff --git a/chrome/browser/prefs/browser_prefs.h b/chrome/browser/prefs/browser_prefs.h

index 9fa2829653cac77457272d2974ff50c56fdae316..82e4baa192c6e2073be5dad17a81deafbc7c3a96 100644

--- a/chrome/browser/prefs/browser_prefs.h

+++ b/chrome/browser/prefs/browser_prefs.h

@@ -31,9 +31,11 @@ void RegisterLoginProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

#endif

// Migrates prefs from |local_state| to |profile|'s pref store.

+// This should always be executed, and will only migrate the newest changes.

gab 2015/02/20 20:33:57 Change this entire comment to something like: //

rkaplow 2015/02/20 21:58:08 Done. Your suggestion SGTM

void MigrateBrowserPrefs(Profile* profile, PrefService* local_state);

gab 2015/02/20 20:33:57 Remove |profile| parameter.

rkaplow 2015/02/20 21:58:08 Done.

// Migrates prefs in |profile|'s pref store.

+// This should always be executed, and will only migrate the newest changes.

gab 2015/02/20 20:33:57 Change this entire comment to something like: //

rkaplow 2015/02/20 21:58:08 Done.

void MigrateUserPrefs(Profile* profile);

gab 2015/02/20 20:33:57 Change the argument from a |Profile* profile| to a

rkaplow 2015/02/20 21:58:08 Done.

// Migrates zoom level prefs in |profile|'s pref store to a per-StoragePartition

« no previous file with comments | « no previous file | chrome/browser/prefs/browser_prefs.cc » ('j') | chrome/browser/prefs/browser_prefs.cc » ('J')