chrome/browser/prefs/browser_prefs.h - Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/prefs/browser_prefs.h

Issue 944433002: Revamp the MigrateBrowserPrefs and MigrateUserPrefs code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: additional cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chromeos/login/default_pinned_apps_field_trial.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | chrome/browser/prefs/browser_prefs.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_PREFS_BROWSER_PREFS_H_	5 #ifndef CHROME_BROWSER_PREFS_BROWSER_PREFS_H_

6 #define CHROME_BROWSER_PREFS_BROWSER_PREFS_H_	6 #define CHROME_BROWSER_PREFS_BROWSER_PREFS_H_

7	7

8 class PrefRegistrySimple;	8 class PrefRegistrySimple;

9 class PrefService;	9 class PrefService;

10 class Profile;	10 class Profile;

(...skipping 12 matching lines...) Expand all Loading...
23 // Register all prefs that will be used via a PrefService attached to a user	23 // Register all prefs that will be used via a PrefService attached to a user

24 // Profile.	24 // Profile.

25 void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry);	25 void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

26	26

27 #if defined(OS_CHROMEOS)	27 #if defined(OS_CHROMEOS)

28 // Register all prefs that will be used via a PrefService attached to the login	28 // Register all prefs that will be used via a PrefService attached to the login

29 // Profile.	29 // Profile.

30 void RegisterLoginProfilePrefs(user_prefs::PrefRegistrySyncable* registry);	30 void RegisterLoginProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

31 #endif	31 #endif

32	32

33 // Migrates prefs from \|local_state\| to \|profile\|'s pref store.	33 // Migrate/cleanup deprecated prefs in \|local_state\|. Over time, long deprecated

34 void MigrateBrowserPrefs(Profile* profile, PrefService* local_state);	34 // prefs should be removed as new ones are added, but this call should never go

	35 // away (even if it becomes an empty call for some time) as it should remain

	36 // the place to drop deprecated browser prefs at.

	37 void MigrateObsoleteBrowserPrefs(Profile* profile, PrefService* local_state);

35	38

36 // Migrates prefs in \|profile\|'s pref store.	39 // Migrate/cleanup deprecated prefs in \|profile\|'s pref store. Over time, long

37 void MigrateUserPrefs(Profile* profile);	40 // deprecated prefs should be removed as new ones are added, but this call

	41 // should never go away (even if it becomes an empty call for some time) as it

	42 // should remain the place to drop deprecated profile prefs at.

	43 void MigrateObsoleteProfilePrefs(Profile* profile);

38	44

39 // Migrates zoom level prefs in \|profile\|'s pref store to a per-StoragePartition	45 // Migrates zoom level prefs in \|profile\|'s pref store to a per-StoragePartition

40 // set of prefs.	46 // set of prefs.

41 void MigrateProfileZoomLevelPrefs(Profile* profile);	47 void MigrateProfileZoomLevelPrefs(Profile* profile);

42	48

43 } // namespace chrome	49 } // namespace chrome

44	50

45 #endif // CHROME_BROWSER_PREFS_BROWSER_PREFS_H_	51 #endif // CHROME_BROWSER_PREFS_BROWSER_PREFS_H_

OLD	NEW