Revamp the MigrateBrowserPrefs and MigrateUserPrefs code.

chrome/browser/prefs/browser_prefs.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/browser_prefs.h"
 
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_registry_simple.h"
@@ skipping 212 matching lines @@
 enum MigratedPreferences {
   NO_PREFS = 0,
   DNS_PREFS = 1 << 0,
   WINDOWS_PREFS = 1 << 1,
 };
 
 // A previous feature (see
 // chrome/browser/protector/protected_prefs_watcher.cc in source
 // control history) used this string as a prefix for various prefs it
 // registered. We keep it here for now to clear out those old prefs in
-// MigrateUserPrefs.
+// MigrateObsoleteProfilePrefs.
 const char kBackupPref[] = "backup";

[gab, 2015/02/23 16:09:38]

Remove it completely.

[rkaplow, 2015/02/23 22:55:04]

Done.

 
 #if !defined(OS_ANDROID)
 // The AutomaticProfileResetter service used this preference to save that the
 // profile reset prompt had already been shown, however, the preference has been
 // renamed in Local State. We keep the name here for now so that we can clear
 // out legacy values.
 // TODO(engedy): Remove this and usages in M42 or later. See crbug.com/398813.
 const char kLegacyProfileResetPromptMemento[] = "profile.reset_prompt_memento";
 #endif
 
 }  // namespace
 
 namespace chrome {
 
 void RegisterLocalState(PrefRegistrySimple* registry) {
-  // Prefs in Local State.
-  registry->RegisterIntegerPref(prefs::kMultipleProfilePrefMigration, 0);
 
   // Please keep this list alphabetized.
   AppListService::RegisterPrefs(registry);
   browser_shutdown::RegisterPrefs(registry);
   BrowserProcessImpl::RegisterPrefs(registry);
   ChromeMetricsServiceClient::RegisterPrefs(registry);
   chrome_prefs::RegisterPrefs(registry);
   chrome_variations::VariationsService::RegisterPrefs(registry);
   component_updater::RegisterPrefsForRecoveryComponent(registry);
   component_updater::SupervisedUserWhitelistInstaller::RegisterPrefs(registry);
@@ skipping 286 matching lines @@
 }
 
 #if defined(OS_CHROMEOS)
 void RegisterLoginProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   RegisterProfilePrefs(registry);
 
   chromeos::PowerPrefs::RegisterLoginProfilePrefs(registry);
 }
 #endif
 
-void MigrateUserPrefs(Profile* profile) {
-  PrefService* prefs = profile->GetPrefs();
+void MigrateObsoleteProfilePrefs(PrefService* profile_prefs) {
+  // This method should prune away migrations year+ old.

[gab, 2015/02/23 16:09:38]

s/migrations year+ old/year+ old migrations/

[gab, 2015/02/23 16:09:38]

s/should prune away/should be pruned from/

(i.e. the method itself doesn't do the pruning)

[rkaplow, 2015/02/23 22:55:04]

Done.

[rkaplow, 2015/02/23 22:55:04]

true, wording was odd ;)

 
-  // Cleanup prefs from now-removed protector feature.
-  prefs->ClearPref(kBackupPref);
+#if defined(OS_MACOSX) && !defined(OS_IOS)
+  // Added 06/2014.
+  autofill::AutofillManager::MigrateUserPrefs(profile_prefs);
+#endif  // defined(OS_MACOSX) && !defined(OS_IOS)
+
+  // Added 07/2014.
+  translate::TranslatePrefs::MigrateUserPrefs(profile_prefs,
+                                              prefs::kAcceptLanguages);
 
 #if !defined(OS_ANDROID)
+  // Added 08/2014.
   // Migrate kNetworkPredictionEnabled to kNetworkPredictionOptions when not on
   // Android.  On Android, platform-specific code performs preference migration.
   // TODO(bnc): https://crbug.com/401970  Remove migration code one year after
   // M38.
-  chrome_browser_net::MigrateNetworkPredictionUserPrefs(prefs);
+  chrome_browser_net::MigrateNetworkPredictionUserPrefs(profile_prefs);
+#endif
+}

[gab, 2015/02/23 16:09:38]

Looks like you'll need to sync/merge again for the new addition of
MigrateGoogleNowPrefs():
https://chromium.googlesource.com/chromium/src/+blame/master/chrome/browser/p...

Also looks like this brings back the dependency on having a Profile* as an
argument... for the sake of simplicity, let's add it back and not try to be
fancier for now.

[rkaplow, 2015/02/23 22:55:04]

Done.

+
+void MigrateObsoleteBrowserPrefs(PrefService* local_state) {
+  // This method should prune away migrations year+ old.

[gab, 2015/02/23 16:09:37]

Same comments as above.

[rkaplow, 2015/02/23 22:55:04]

Done.

+
+  // Added 05/2014.
+#if defined(TOOLKIT_VIEWS)
+  MigrateBrowserTabStripPrefs(local_state);
 #endif
 
-  PromoResourceService::MigrateUserPrefs(prefs);
-  translate::TranslatePrefs::MigrateUserPrefs(prefs, prefs::kAcceptLanguages);
-
-#if defined(OS_MACOSX) && !defined(OS_IOS)
-  autofill::AutofillManager::MigrateUserPrefs(prefs);
-#endif  // defined(OS_MACOSX) && !defined(OS_IOS)
-}
-
-void MigrateBrowserPrefs(Profile* profile, PrefService* local_state) {
-  // Copy pref values which have been migrated to user_prefs from local_state,
-  // or remove them from local_state outright, if copying is not required.
-  int current_version =
-      local_state->GetInteger(prefs::kMultipleProfilePrefMigration);
-  PrefRegistrySimple* registry = static_cast<PrefRegistrySimple*>(
-      local_state->DeprecatedGetPrefRegistry());

[gab, 2015/02/23 16:09:38]

Woot, one less call to DeprecatedGetPrefRegistry() :-)

[rkaplow, 2015/02/23 23:27:52]

:)

-
-  if (!(current_version & DNS_PREFS)) {

[gab, 2015/02/23 16:09:37]

Looks like you can now also get rid of the enum defining DNS_PREFS and
WINDOW_PREFS :-)

[rkaplow, 2015/02/23 23:27:52]

Done.

-    registry->RegisterListPref(prefs::kDnsStartupPrefetchList);
-    local_state->ClearPref(prefs::kDnsStartupPrefetchList);
-
-    registry->RegisterListPref(prefs::kDnsHostReferralList);
-    local_state->ClearPref(prefs::kDnsHostReferralList);
-
-    current_version |= DNS_PREFS;
-    local_state->SetInteger(prefs::kMultipleProfilePrefMigration,
-                            current_version);
-  }
-
-  PrefService* user_prefs = profile->GetPrefs();
-  if (!(current_version & WINDOWS_PREFS)) {
-    registry->RegisterDictionaryPref(prefs::kBrowserWindowPlacement);
-    if (local_state->HasPrefPath(prefs::kBrowserWindowPlacement)) {
-      const PrefService::Preference* pref =
-          local_state->FindPreference(prefs::kBrowserWindowPlacement);
-      DCHECK(pref);
-      user_prefs->Set(prefs::kBrowserWindowPlacement,
-                      *(pref->GetValue()));
-    }
-    local_state->ClearPref(prefs::kBrowserWindowPlacement);
-
-    current_version |= WINDOWS_PREFS;
-    local_state->SetInteger(prefs::kMultipleProfilePrefMigration,
-                            current_version);
-  }
-
+  // Added 08/2014.
 #if !defined(OS_ANDROID)
   local_state->ClearPref(kLegacyProfileResetPromptMemento);
 #endif
-
-#if defined(OS_CHROMEOS)
-  chromeos::default_pinned_apps_field_trial::MigratePrefs(local_state);

[gab, 2015/02/23 16:09:38]

Also clean up this no longer call method (and all of its file it looks like!):
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

[rkaplow, 2015/02/23 23:27:52]

Done.

-#endif
-
-#if defined(TOOLKIT_VIEWS)
-  MigrateBrowserTabStripPrefs(local_state);

[gab, 2015/02/23 16:09:38]

Also remove call (and associated registrations) @
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[rkaplow, 2015/02/23 23:27:52]

Done.

-#endif
 }
 
 // As part of the migration from per-profile to per-partition HostZoomMaps,
 // we need to detect if an existing per-profile set of preferences exist, and
 // if so convert them to be per-partition. We migrate any per-profile zoom
 // level prefs via zoom_level_prefs.
 // Code that updates zoom prefs in the profile prefs store has been removed,
 // so once we clear these values here, they should never get set again.
 // TODO(wjmaclean): Remove this migration machinery after histograms show
 // that an aceptable percentage of users have been migrated.
@@ skipping 36 matching lines @@
       host_zoom_dictionary, false /* sanitize_partition_host_zoom_levels */);
 
   // We're done migrating the profile per-host zoom level values, so we clear
   // them all.
   DictionaryPrefUpdate host_zoom_dictionary_update(
       prefs, prefs::kPerHostZoomLevelsDeprecated);
   host_zoom_dictionary_update->Clear();
 }
 
 }  // namespace chrome