Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 944413003: Add support for setting properties to requests uploading contents. (Closed)

Created:
5 years, 10 months ago by mtomasz
Modified:
5 years, 10 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for setting properties to requests uploading contents. This CL adds support to setting properties to all requests which are used by EntryUpdatePerformer. TEST=google_apis_unittests BUG=451113 Committed: https://crrev.com/f2b838038376370a64ab3e284e83a1979db4b392 Cr-Commit-Position: refs/heads/master@{#317753}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added properties to FilesInsertRequest. #

Total comments: 4

Patch Set 3 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -149 lines) Patch
M chrome/browser/drive/drive_api_service.cc View 1 5 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 3 chunks +10 lines, -0 lines 0 comments Download
M google_apis/drive/base_requests.h View 3 chunks +7 lines, -15 lines 0 comments Download
M google_apis/drive/base_requests.cc View 2 chunks +2 lines, -43 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 1 10 chunks +20 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 2 10 chunks +106 lines, -50 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 2 9 chunks +46 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mtomasz
https://codereview.chromium.org/944413003/diff/1/google_apis/drive/drive_api_requests.cc File google_apis/drive/drive_api_requests.cc (right): https://codereview.chromium.org/944413003/diff/1/google_apis/drive/drive_api_requests.cc#newcode79 google_apis/drive/drive_api_requests.cc:79: std::string CreateMultipartUploadMetadataJson( This is copy paste from base_requests.cc + ...
5 years, 10 months ago (2015-02-23 09:12:52 UTC) #1
mtomasz
@hashimoto: PTAL. Thanks.
5 years, 10 months ago (2015-02-23 09:13:02 UTC) #3
hashimoto
lgtm https://codereview.chromium.org/944413003/diff/20001/google_apis/drive/drive_api_requests.cc File google_apis/drive/drive_api_requests.cc (right): https://codereview.chromium.org/944413003/diff/20001/google_apis/drive/drive_api_requests.cc#newcode97 google_apis/drive/drive_api_requests.cc:97: if (!modified_date.is_null()) nit: Please add {} while you ...
5 years, 10 months ago (2015-02-23 10:16:20 UTC) #4
mtomasz
https://codereview.chromium.org/944413003/diff/20001/google_apis/drive/drive_api_requests.cc File google_apis/drive/drive_api_requests.cc (right): https://codereview.chromium.org/944413003/diff/20001/google_apis/drive/drive_api_requests.cc#newcode97 google_apis/drive/drive_api_requests.cc:97: if (!modified_date.is_null()) On 2015/02/23 10:16:20, hashimoto wrote: > nit: ...
5 years, 10 months ago (2015-02-24 02:30:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944413003/40001
5 years, 10 months ago (2015-02-24 03:17:57 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-24 03:59:33 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 04:00:20 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f2b838038376370a64ab3e284e83a1979db4b392
Cr-Commit-Position: refs/heads/master@{#317753}

Powered by Google App Engine
This is Rietveld 408576698