DevTools: migrate treeoutline from hasChildren to is/setExpandable().

Source/devtools/front_end/components/ObjectPropertiesSection.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 159 matching lines @@
             this.startEditing(event);
         return false;
     },
 
     /**
      * @override
      */
     onattach: function()
     {
         this.update();
+        if (this.property.value)

[sergeyv, 2015/02/24 13:03:16]

lets move this to constructor

+            this.setExpandable(this.property.value.hasChildren && !this.property.wasThrown);
     },
 
     update: function()
     {
         this.nameElement = WebInspector.ObjectPropertiesSection.createNameElement(this.property.name);
         if (!this.property.enumerable)
             this.nameElement.classList.add("dimmed");
         if (this.property.isAccessorProperty())
             this.nameElement.classList.add("properties-accessor-property-name");
         if (this.property.symbol)
             this.nameElement.addEventListener("contextmenu", this._contextMenuFired.bind(this, this.property.symbol), false);
 
         if (this.property.value) {
             this.valueElement = WebInspector.ObjectPropertiesSection.createValueElement(this.property.value, this.property.wasThrown, this.listItemElement);
             this.valueElement.addEventListener("contextmenu", this._contextMenuFired.bind(this, this.property.value), false);
-            this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown;
         } else if (this.property.getter) {
             this.valueElement = WebInspector.ObjectPropertyTreeElement.createRemoteObjectAccessorPropertySpan(this.property.parentObject, [this.property.name], this._onInvokeGetterClick.bind(this));
         } else {
             this.valueElement = createElementWithClass("span", "console-formatted-undefined");
             this.valueElement.textContent = WebInspector.UIString("<unreadable>");
             this.valueElement.title = WebInspector.UIString("No property getter");
         }
 
         var separatorElement = createElementWithClass("span", "separator");
         separatorElement.textContent = ": ";
@@ skipping 27 matching lines @@
         if (WebInspector.isBeingEdited(this.valueElement) || !this.treeOutline.section.editable || this._readOnly)
             return;
 
         // Edit original source.
         if (typeof valueToEdit !== "undefined")
             this.valueElement.setTextContentTruncatedIfNeeded(valueToEdit, WebInspector.UIString("<string is too large to edit>"));
 
         var context = { expanded: this.expanded, previousContent: this.valueElement.textContent };
 
         // Lie about our children to prevent expanding on double click and to collapse subproperties.
-        this.hasChildren = false;
+        this.setExpandable(false);
 
         this.listItemElement.classList.add("editing-sub-part");
 
         this._prompt = new WebInspector.ObjectPropertyPrompt();
 
         /**
          * @this {WebInspector.ObjectPropertyTreeElement}
          */
         function blurListener()
         {
@@ skipping 266 matching lines @@
     return rootElement;
 }
 
 /**
  * @constructor
  * @extends {TreeElement}
  * @param {!WebInspector.RemoteObject} remoteObject
  */
 WebInspector.FunctionScopeMainTreeElement = function(remoteObject)
 {
-    TreeElement.call(this, "<function scope>");
+    TreeElement.call(this, "<function scope>", true);
     this.toggleOnClick = true;
     this.selectable = false;
     this._remoteObject = remoteObject;
-    this.hasChildren = true;
 }
 
 WebInspector.FunctionScopeMainTreeElement.prototype = {
     onpopulate: function()
     {
         /**
          * @param {?WebInspector.DebuggerModel.FunctionDetails} response
          * @this {WebInspector.FunctionScopeMainTreeElement}
          */
         function didGetDetails(response)
@@ skipping 62 matching lines @@
     __proto__: TreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {TreeElement}
  * @param {!WebInspector.RemoteObject} remoteObject
  */
 WebInspector.CollectionEntriesMainTreeElement = function(remoteObject)
 {
-    TreeElement.call(this, "<entries>");
+    TreeElement.call(this, "<entries>", true);
     this.toggleOnClick = true;
     this.selectable = false;
     this._remoteObject = remoteObject;
-    this.hasChildren = true;
     this.expand();
 }
 
 WebInspector.CollectionEntriesMainTreeElement.prototype = {
     onpopulate: function()
     {
         /**
          * @param {?Array.<!DebuggerAgent.CollectionEntry>} entries
          * @this {WebInspector.CollectionEntriesMainTreeElement}
          */
@@ skipping 27 matching lines @@
 }
 
 /**
  * @constructor
  * @extends {TreeElement}
  * @param {string} title
  * @param {!WebInspector.RemoteObject} remoteObject
  */
 WebInspector.ScopeTreeElement = function(title, remoteObject)
 {
-    TreeElement.call(this, title);
+    TreeElement.call(this, title, true);
     this.toggleOnClick = true;
     this.selectable = false;
     this._remoteObject = remoteObject;
-    this.hasChildren = true;
 }
 
 WebInspector.ScopeTreeElement.prototype = {
     onpopulate: function()
     {
         WebInspector.ObjectPropertyTreeElement._populate(this, this._remoteObject, false);
     },
 
     __proto__: TreeElement.prototype
 }
 
 /**
  * @constructor
  * @extends {TreeElement}
  * @param {!WebInspector.RemoteObject} object
  * @param {number} fromIndex
  * @param {number} toIndex
  * @param {number} propertyCount
  */
 WebInspector.ArrayGroupingTreeElement = function(object, fromIndex, toIndex, propertyCount)
 {
     TreeElement.call(this, String.sprintf("[%d \u2026 %d]", fromIndex, toIndex), true);
     this.toggleOnClick = true;
     this.selectable = false;
     this._fromIndex = fromIndex;
     this._toIndex = toIndex;
     this._object = object;
     this._readOnly = true;
     this._propertyCount = propertyCount;
-    this._populated = false;
 }
 
 WebInspector.ArrayGroupingTreeElement._bucketThreshold = 100;
 WebInspector.ArrayGroupingTreeElement._sparseIterationThreshold = 250000;
 WebInspector.ArrayGroupingTreeElement._getOwnPropertyNamesThreshold = 500000;
 
 /**
  * @param {!TreeElement} treeNode
  * @param {!WebInspector.RemoteObject} object
  * @param {number} fromIndex
@@ skipping 249 matching lines @@
             var childTreeElement = new WebInspector.ObjectPropertyTreeElement(properties[i]);
             childTreeElement._readOnly = true;
             treeNode.appendChild(childTreeElement);
         }
     }
 }
 
 WebInspector.ArrayGroupingTreeElement.prototype = {
     onpopulate: function()
     {
-        if (this._populated)
-            return;
-
-        this._populated = true;
-
         if (this._propertyCount >= WebInspector.ArrayGroupingTreeElement._bucketThreshold) {
             WebInspector.ArrayGroupingTreeElement._populateRanges(this, this._object, this._fromIndex, this._toIndex, false);
             return;
         }
         WebInspector.ArrayGroupingTreeElement._populateAsFragment(this, this._object, this._fromIndex, this._toIndex);
     },
 
     onattach: function()
     {
         this.listItemElement.classList.add("name");
@@ skipping 96 matching lines @@
         value.highlightAsDOMNode();
     }
 
     function mouseLeave()
     {
         value.hideDOMNodeHighlight();
     }
 
     return valueElement;
 }