src/IceTargetLoweringX8632.cpp - Issue 944333002: Subzero: Update tests and build scripts for sandboxing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 944333002: Subzero: Update tests and build scripts for sandboxing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: More code review changes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index 13476c8ec4229fdf4209ccebe2ba0c48b8dc5e31..32102df20483242262ee76f63a72ca80ad268ea4 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -4118,9 +4118,7 @@ TargetX8632::eliminateNextVectorSextInstruction(Variable *SignExtendedResult) {

}

-void TargetX8632::lowerUnreachable(const InstUnreachable * /*Inst*/) {

- _ud2();

+void TargetX8632::lowerUnreachable(const InstUnreachable * /*Inst*/) { _ud2(); }

// Turn an i64 Phi instruction into a pair of i32 Phi instructions, to

// preserve integrity of liveness analysis. Undef values are also

« no previous file with comments | « src/IceTargetLowering.cpp ('k') | tests_lit/assembler/x86/sandboxing.ll » ('j') | no next file with comments »