Consume EXCEPTION_INVALID_HANDLE on sandbox process shutdown.

chrome/app/client_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <shlwapi.h>
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 76 matching lines @@
 
 typedef int (*InitMetro)();
 
 // Returns the directory in which the currently running executable resides.
 base::FilePath GetExecutableDir() {
   base::char16 path[MAX_PATH];
   ::GetModuleFileNameW(nullptr, path, MAX_PATH);
   return base::FilePath(path).DirName();
 }
 
+bool IsSandboxedProcess() {
+  typedef bool (*IsSandboxedProcessFunc)();
+  IsSandboxedProcessFunc is_sandboxed_process_func =
+      reinterpret_cast<IsSandboxedProcessFunc>(
+          GetProcAddress(GetModuleHandle(NULL), "IsSandboxedProcess"));
+  bool is_sandboxed_process =
+      is_sandboxed_process_func && is_sandboxed_process_func();
+  return is_sandboxed_process;
+}
+
 }  // namespace
 
 base::string16 GetCurrentModuleVersion() {
   scoped_ptr<FileVersionInfo> file_version_info(
       FileVersionInfo::CreateFileVersionInfoForCurrentModule());
   if (file_version_info.get()) {
     base::string16 version_string(file_version_info->file_version());
     if (Version(base::UTF16ToASCII(version_string)).IsValid())
       return version_string;
   }
@@ skipping 121 matching lines @@
   if (!dll_)
     return chrome::RESULT_CODE_MISSING_DATA;
 
   scoped_ptr<base::Environment> env(base::Environment::Create());
   env->SetVar(chrome::kChromeVersionEnvVar, base::WideToUTF8(version));
 
   OnBeforeLaunch(process_type_, file);
   DLL_MAIN chrome_main =
       reinterpret_cast<DLL_MAIN>(::GetProcAddress(dll_, "ChromeMain"));
   int rc = chrome_main(instance, &sandbox_info);
-  return OnBeforeExit(rc, file);
+  rc = OnBeforeExit(rc, file);
+  // Sandboxed processes close some system DLL handles after lockdown so ignore
+  // EXCEPTION_INVALID_HANDLE generated on Windows 10 during shutdown of these
+  // processes.
+  // TODO(wfh): Check whether MS have fixed this in Win10 RTM. crbug.com/456193
+  if (base::win::GetVersion() >= base::win::VERSION_WIN10 &&
+      IsSandboxedProcess()) {
+    breakpad::ConsumeInvalidHandleExceptions();

[rvargas (doing something else), 2015/02/25 02:02:57]

Drive by:

I don't know what this code does (don't see it anywhere), but all exceptions are
not equal. Some require extra work when handling them.

I believe that invalid exception is on the non-trivial side.
See: https://code.google.com/p/chromium/issues/detail?id=131699#c25

Maybe it's already taken care of...

+  }
+  return rc;
 }
 
 void MainDllLoader::RelaunchChromeBrowserWithNewCommandLineIfNeeded() {
   if (!dll_)
     return;
 
   RelaunchChromeBrowserWithNewCommandLineIfNeededFunc relaunch_function =
       reinterpret_cast<RelaunchChromeBrowserWithNewCommandLineIfNeededFunc>(
           ::GetProcAddress(dll_,
                            "RelaunchChromeBrowserWithNewCommandLineIfNeeded"));
@@ skipping 55 matching lines @@
   }
 };
 
 MainDllLoader* MakeMainDllLoader() {
 #if defined(GOOGLE_CHROME_BUILD)
   return new ChromeDllLoader();
 #else
   return new ChromiumDllLoader();
 #endif
 }