Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 944193003: Add a dedicated pretty-diff command. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a dedicated pretty-diff command. This will let us delete webkit-patch and a bunch of python code and it will save me some annoyance at needing to type "webkit-patch pretty-diff" all the time. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3c87a7717325aad6f5a8dc3c5de9a93242e42d4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -39 lines) Patch
A + sky/tools/pretty-diff View 1 chunk +49 lines, -39 lines 0 comments Download
M sky/tools/webkitpy/common/checkout/scm/git.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-21 05:00:46 UTC) #2
ojan
5 years, 10 months ago (2015-02-21 05:01:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c87a7717325aad6f5a8dc3c5de9a93242e42d4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698