HostTableEntry refactor

remoting/webapp/crd/js/local_host_section.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var remoting = remoting || {};
+
+(function() {
+
+'use strict';
+
+/**
+ * @param {HTMLElement} rootElement
+ * @param {remoting.LocalHostSection.Controller} controller
+ * @constructor
+ */
+remoting.LocalHostSection = function(rootElement, controller) {
+  /** @private */
+  this.rootElement_ = rootElement;
+  /** @private */
+  this.controller_ = controller;
+  /** @private {remoting.Host} */
+  this.host_ = null;
+  /** @private {remoting.HostController.State} */
+  this.state_ = remoting.HostController.State.UNKNOWN;
+
+  var hostContainer = rootElement.querySelector('.host-entry');
+  var webappVersion = parseInt(chrome.runtime.getManifest().version, 10);

[Jamie, 2015/02/23 22:28:11]

I don't think you need to store this. Just query it every time--it's only called
if you connect.

[kelvinp, 2015/02/24 22:04:45]

Done.

[Jamie, 2015/02/27 18:19:40]

I don't think you've changed this. To clarify my objection, since we call the
ctor in two places, we shouldn't be passing in the webappMajorVersion, since
that means duplicating the code to compute it. Instead, just compute it in
needsUpdate--there's no need for it to be a HostTableEntry class member.

+  /** @private */
+  this.hostTableEntry_ =
+      new remoting.HostTableEntry(webappVersion, this.rename_.bind(this));
+  hostContainer.appendChild(this.hostTableEntry_.element());
+
+  var startButton = rootElement.querySelector('#start-daemon');
+  var stopButton = rootElement.querySelector('#stop-daemon');
+  var changePINButton = rootElement.querySelector('#change-daemon-pin');
+  /** @private */
+  this.eventHooks_ = new base.Disposables(

[Jamie, 2015/02/23 22:28:11]

Do you need a dispose() method to delete these?

[kelvinp, 2015/02/24 22:04:45]

Done.

+    new base.DomEventHook(startButton, 'click', controller.start, false),
+    new base.DomEventHook(stopButton, 'click', controller.stop, false),
+    new base.DomEventHook(changePINButton, 'click', controller.changePIN, false)
+  );
+};
+
+/**
+ * @param {remoting.Host} host
+ * @param {remoting.HostController.State} state
+ */
+remoting.LocalHostSection.prototype.setModel = function(host, state) {
+  this.host_ = host;
+  this.state_ = state;
+  this.updateUI_();
+};
+
+/**
+ * @return {?string}
+ */
+remoting.LocalHostSection.prototype.getHostId = function() {
+  return this.host_ ? this.host_.hostId : null;
+};
+
+/** @return {boolean} */
+remoting.LocalHostSection.prototype.canChangeState = function() {
+  // The local host cannot be stopped or started if the host controller is not
+  // implemented for this platform. Additionally, it cannot be started if there
+  // is an error (in many error states, the start operation will fail anyway,
+  // but even if it succeeds, the chance of a related but hard-to-diagnose
+  // future error is high).
+  var state = this.state_;
+  return (state != remoting.HostController.State.NOT_IMPLEMENTED) &&
+         (state != remoting.HostController.State.UNKNOWN) &&
+         (state != remoting.HostController.State.NOT_INSTALLED ||
+          remoting.isMe2MeInstallable());
+};
+
+/** @private */
+remoting.LocalHostSection.prototype.updateUI_ = function() {
+  this.hostTableEntry_.setHost(this.host_);
+
+  // Disable elements.
+  var enabled = (this.state_ == remoting.HostController.State.STARTING) ||
+      (this.state_ == remoting.HostController.State.STARTED);
+  var canChangeLocalHostState = this.canChangeState();
+  remoting.updateModalUi(enabled ? 'enabled' : 'disabled', 'data-daemon-state');
+  this.rootElement_.hidden = !canChangeLocalHostState;
+};
+
+remoting.LocalHostSection.prototype.rename_ = function() {
+  return this.controller_.rename(this.hostTableEntry_);
+};
+
+/**
+ * @constructor
+ * @param {remoting.HostList} hostList
+ */
+remoting.LocalHostSection.Controller = function(hostList) {
+  /** @private */
+  this.hostList_ = hostList;
+};
+
+remoting.LocalHostSection.Controller.prototype.start = function() {
+  remoting.hostSetupDialog.showForStart();
+};
+
+remoting.LocalHostSection.Controller.prototype.stop = function() {
+  remoting.hostSetupDialog.showForStop();
+};
+
+remoting.LocalHostSection.Controller.prototype.changePIN = function() {
+  remoting.hostSetupDialog.showForPin();
+};
+
+/** @param {remoting.HostTableEntry} host */
+remoting.LocalHostSection.Controller.prototype.rename = function(host) {
+  this.hostList_.renameHost(host);
+};
+
+}());
+