Expose a method to invalidate menu item content

Expose a method to invalidate menu item content

- Expose a way to cause the ListAdapter to refresh the MenuItem content of it's MenuItem list.

BUG=459409
Committed: https://crrev.com/b82a480da152650228090c13ac26b1582b0b8896
Cr-Commit-Position: refs/heads/master@{#318122}

[David Trainor- moved to gerrit, 2015-02-20 23:20:26]

dtrainor@chromium.org changed reviewers:
+ aurimas@chromium.org

[David Trainor- moved to gerrit, 2015-02-20 23:20:30]

ptal

[aurimas (slooooooooow), 2015-02-20 23:25:13]

lgtm

https://chromiumcodereview.appspot.com/944173002/diff/1/chrome/android/java/s...
File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
(right):

https://chromiumcodereview.appspot.com/944173002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:85: if
(mAdapter != null) mAdapter.notifyDataSetChanged();
How expensive is this?

[David Trainor- moved to gerrit, 2015-02-23 19:40:26]

https://chromiumcodereview.appspot.com/944173002/diff/1/chrome/android/java/s...
File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
(right):

https://chromiumcodereview.appspot.com/944173002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:85: if
(mAdapter != null) mAdapter.notifyDataSetChanged();
On 2015/02/20 23:25:13, aurimas wrote:
> How expensive is this?

Not free?  I'll get some measurements though, but we are changing the visuals of
the menu and telling the DropDownListView that it needs to re-query the
ListAdapter for data so I'm sure it isn't super cheap.  To be fair, I would
imagine this happens pretty rarely.

But to your point, I can add some code to delay this until after any animations
are done.  That would help make sure it doesn't impact the animation behavior
and is a good idea :).

[David Trainor- moved to gerrit, 2015-02-24 22:28:45]

Looks like the call takes around 10ms or so.  I make sure we don't do it during
any animations.

[aurimas (slooooooooow), 2015-02-25 00:35:29]

On 2015/02/24 at 22:28:45, dtrainor wrote:
> Looks like the call takes around 10ms or so.  I make sure we don't do it
during any animations.

We only need to change the accessibility string for one icon. That seems kind of
crazy that we have to do 10ms of work for that. Can you think of any other way?
Maybe we could specify to refresh a specific menu item?

[David Trainor- moved to gerrit, 2015-02-25 01:40:45]

Should now just update the single menu item row.

[aurimas (slooooooooow), 2015-02-25 01:42:12]

lgtm

[David Trainor- moved to gerrit, 2015-02-25 21:33:43]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-02-25 21:33:43]

The patchset sent to the CQ was uploaded after l-g-t-m from aurimas@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/944173002/#ps60001
(title: "Added null check for ListView")

[commit-bot: I haz the power, 2015-02-25 21:34:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/944173002/60001

[commit-bot: I haz the power, 2015-02-25 21:39:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-25 21:41:15]

Patchset 4 (id:??) landed as
https://crrev.com/b82a480da152650228090c13ac26b1582b0b8896
Cr-Commit-Position: refs/heads/master@{#318122}