Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 944163004: Files.app: Add new metadata model to Gallery.app. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add new metadata model to Gallery.app. The CL just adds new metadata model as a member varaiables of gallery models. The following CL replaces existing metadata model with the new model. BUG=410766 TEST=None Committed: https://crrev.com/d08dbefe19c25b332e3525fe59278e9ec4ab80de Cr-Commit-Position: refs/heads/master@{#318005}

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 2

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -14 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +9 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 3 chunks +10 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model.js View 1 2 2 chunks +13 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model_unittest.js View 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 3 chunks +11 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-25 06:30:33 UTC) #2
yawano
lgtm with nit. https://codereview.chromium.org/944163004/diff/20001/ui/file_manager/gallery/js/gallery_data_model.js File ui/file_manager/gallery/js/gallery_data_model.js (right): https://codereview.chromium.org/944163004/diff/20001/ui/file_manager/gallery/js/gallery_data_model.js#newcode26 ui/file_manager/gallery/js/gallery_data_model.js:26: * @type {!FileSystemMetadata} very small nit: ...
5 years, 10 months ago (2015-02-25 06:39:54 UTC) #3
hirono
https://codereview.chromium.org/944163004/diff/20001/ui/file_manager/gallery/js/gallery_data_model.js File ui/file_manager/gallery/js/gallery_data_model.js (right): https://codereview.chromium.org/944163004/diff/20001/ui/file_manager/gallery/js/gallery_data_model.js#newcode26 ui/file_manager/gallery/js/gallery_data_model.js:26: * @type {!FileSystemMetadata} On 2015/02/25 06:39:54, yawano wrote: > ...
5 years, 10 months ago (2015-02-25 06:45:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944163004/40001
5 years, 10 months ago (2015-02-25 07:21:20 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 09:42:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 09:43:26 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d08dbefe19c25b332e3525fe59278e9ec4ab80de
Cr-Commit-Position: refs/heads/master@{#318005}

Powered by Google App Engine
This is Rietveld 408576698