Issue 944153002: Add device dependency GN's header checker found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 944153002: Add device dependency GN's header checker found. (Closed)

Created:
5 years, 10 months ago by brettw

Modified:
5 years, 10 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add device dependency GN's header checker found. BUG= Committed: https://crrev.com/017d36b6d7cb46e7f0c5102e2f0065411e2386b7 Cr-Commit-Position: refs/heads/master@{#317455}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	device/usb/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

brettw

Long story: A patch a while ago was reverted because of this on a win8 ...

5 years, 10 months ago (2015-02-21 00:19:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944153002/1

5 years, 10 months ago (2015-02-21 00:28:50 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-21 00:48:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/017d36b6d7cb46e7f0c5102e2f0065411e2386b7
Cr-Commit-Position: refs/heads/master@{#317455}