tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py - Issue 944133002: Log a warning and do not try to launch crash service if binary not found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

Issue 944133002: Log a warning and do not try to launch crash service if binary not found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

index d58a1a75f2e2893c49e84f2c53a67722a510e837..0b4d5e209f2e9adfd23989e8d88e5916cdb0759d 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

@@ -102,8 +102,13 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

if os_name != 'win':

return None

arch_name = self.browser.platform.GetArchName()

+ command = support_binaries.FindPath('crash_service', arch_name, os_name)

+ if not command:

+ logging.warning('crash_service.exe not found for %s %s',

+ arch_name, os_name)

+ return None

return subprocess.Popen([

- support_binaries.FindPath('crash_service', arch_name, os_name),

+ command,

'--no-window',

'--dumps-dir=%s' % self._tmp_minidump_dir,

'--pipe-name=%s' % self._GetCrashServicePipeName()])

« no previous file with comments | « no previous file | no next file » | no next file with comments »