chrome/browser/ui/views/frame/browser_view.cc - Issue 944123003: Hack webapp to request keyboard events on connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 944123003: Hack webapp to request keyboard events on connection. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Hacked up chromoting client and using mouse lock instead of keyboard lock for bubble. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 33ee5a13f0b62b91d5e3536a09e95e27b1a61112..ae8221ee88e0b28bfee1f8f025b76b34f310c5e5 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -64,6 +64,7 @@

#include "chrome/browser/ui/views/download/download_in_progress_dialog_view.h"

#include "chrome/browser/ui/views/download/download_shelf_view.h"

#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"

+#include "chrome/browser/ui/views/exclusive_access_bubble_views_context_browser.h"

#include "chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h"

#include "chrome/browser/ui/views/frame/browser_view_layout.h"

#include "chrome/browser/ui/views/frame/browser_view_layout_delegate.h"

@@ -958,8 +959,9 @@ void BrowserView::UpdateFullscreenExitBubbleContent(

} else if (exclusive_access_bubble_.get()) {

exclusive_access_bubble_->UpdateContent(url, bubble_type);

} else {

- exclusive_access_bubble_.reset(

- new ExclusiveAccessBubbleViews(this, url, bubble_type));

+ // TODO(sriramsr): HACK LEAKS memeory - might want to merge with this clas.

+ exclusive_access_bubble_.reset(new ExclusiveAccessBubbleViews(

+ new ExclusiveAccessBubbleViewsContextBrowser(this), url, bubble_type));

}