Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 944103002: Add note about availability to printerProvider API description (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add note about availability to printerProvider API description The API is available only on Chrome 42 dev channel, but it's listed as a stable API since 40 on developer.chrome.com Adding a note about availability yo API description until this is fixed. Committed: https://crrev.com/718d3b4537b49785d29e5fb4eb9b164d010785d6 Cr-Commit-Position: refs/heads/master@{#317414}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M extensions/common/api/printer_provider.idl View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tbarzic
5 years, 10 months ago (2015-02-20 21:03:22 UTC) #2
not at google - send to devlin
avaiability --> availability https://codereview.chromium.org/944103002/diff/1/extensions/common/api/printer_provider.idl File extensions/common/api/printer_provider.idl (right): https://codereview.chromium.org/944103002/diff/1/extensions/common/api/printer_provider.idl#newcode8 extensions/common/api/printer_provider.idl:8: // Available only on dev channel ...
5 years, 10 months ago (2015-02-20 21:05:27 UTC) #3
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-20 21:05:32 UTC) #4
tbarzic
https://codereview.chromium.org/944103002/diff/1/extensions/common/api/printer_provider.idl File extensions/common/api/printer_provider.idl (right): https://codereview.chromium.org/944103002/diff/1/extensions/common/api/printer_provider.idl#newcode8 extensions/common/api/printer_provider.idl:8: // Available only on dev channel since Chrome 42. ...
5 years, 10 months ago (2015-02-20 21:10:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944103002/20001
5 years, 10 months ago (2015-02-20 21:11:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 22:00:12 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 22:01:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/718d3b4537b49785d29e5fb4eb9b164d010785d6
Cr-Commit-Position: refs/heads/master@{#317414}

Powered by Google App Engine
This is Rietveld 408576698