Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 944083004: Set default page scale limits in layout test preferences (Closed)

Created:
5 years, 10 months ago by bokan
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set default page scale limits in layout test preferences. The default page scale limits are now set in the same place as the rest of layout test preferences. This prevents them from being set to the platform default when WebKitTestRunner reapplies WebPreferences, in this case, from Reset(). Also removed setPageScaleFactor from Reset() since resetInternalsObject will do this so this call was effectively a no-op. BUG=450605 Committed: https://crrev.com/9a9792d0a9c76755ee3667091544b36aa04fad16 Cr-Commit-Position: refs/heads/master@{#318119}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/shell/common/webkit_test_helpers.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
bokan
Made a new CL from: https://codereview.chromium.org/938013002/ since I changed repo. The correct fix here I ...
5 years, 10 months ago (2015-02-23 17:07:26 UTC) #2
aelias_OOO_until_Jul13
lgtm
5 years, 10 months ago (2015-02-23 20:11:58 UTC) #3
bokan
+avi@ for OWNER
5 years, 10 months ago (2015-02-23 20:34:25 UTC) #5
bokan
ping
5 years, 10 months ago (2015-02-25 19:47:27 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-25 20:29:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944083004/1
5 years, 10 months ago (2015-02-25 20:31:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 21:25:25 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 21:26:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a9792d0a9c76755ee3667091544b36aa04fad16
Cr-Commit-Position: refs/heads/master@{#318119}

Powered by Google App Engine
This is Rietveld 408576698