Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1981)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 944053004: OffscreenPreRaster and its plumbings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
index 2d33f5294be0ea5b681e783881b2ac42bc7314ea..03a66c38213469c953010d7c35d4e48a37b44059 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
@@ -88,6 +88,7 @@ public class AwSettings {
private boolean mEnableSupportedHardwareAcceleratedFeatures = false;
private int mMixedContentMode = MIXED_CONTENT_NEVER_ALLOW;
private boolean mVideoOverlayForEmbeddedVideoEnabled = false;
+ private boolean mOffscreenPreRaster = false;
// Although this bit is stored on AwSettings it is actually controlled via the CookieManager.
private boolean mAcceptThirdPartyCookies = false;
@@ -1559,6 +1560,45 @@ public class AwSettings {
|| mMixedContentMode == MIXED_CONTENT_COMPATIBILITY_MODE;
}
+ public boolean getOffscreenPreRaster() {
+ synchronized (mAwSettingsLock) {
+ return getOffscreenPreRasterLocked();
+ }
+ }
+
+ @CalledByNative
+ private boolean getOffscreenPreRasterLocked() {
+ assert Thread.holdsLock(mAwSettingsLock);
+ return mOffscreenPreRaster;
+ }
+
+ /**
+ * Sets whether this WebView should raster tiles when it is
+ * offscreen but attached to window. Turning this on can avoid
+ * rendering artifacts when animating an offscreen WebView on-screen.
+ * In particular, insertVisualStateCallback requires this mode to function.
+ * Offscreen WebViews in this mode uses more memory. Please follow
+ * these guidelines to limit memory usage:
+ * - Webview size should be not be larger than the device screen size.
+ * - Limit simple mode to a small number of webviews. Use it for
+ *   visible webviews and webviews about to be animated to visible.
+ */
+ public void setOffscreenPreRaster(boolean enabled) {
+ synchronized (mAwSettingsLock) {
+ if (enabled != mOffscreenPreRaster) {
+ mOffscreenPreRaster = enabled;
+ mEventHandler.runOnUiThreadBlockingAndLocked(new Runnable() {
+ @Override
+ public void run() {
+ if (mNativeAwSettings != 0) {
+ nativeUpdateOffscreenPreRasterLocked(mNativeAwSettings);
+ }
+ }
+ });
+ }
+ }
+ }
+
/**
* Sets whether to use the video overlay for the embedded video.
* @param flag whether to enable the video overlay for the embedded video.
@@ -1671,4 +1711,6 @@ public class AwSettings {
private native void nativeUpdateFormDataPreferencesLocked(long nativeAwSettings);
private native void nativeUpdateRendererPreferencesLocked(long nativeAwSettings);
+
+ private native void nativeUpdateOffscreenPreRasterLocked(long nativeAwSettings);
}

Powered by Google App Engine
This is Rietveld 408576698