PPAPI: Whitelist PPB_CameraDevice_Private for some apps

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 163 matching lines @@
 using blink::WebURLError;
 using blink::WebURLRequest;
 using blink::WebURLResponse;
 using blink::WebVector;
 
 namespace {
 
 ChromeContentRendererClient* g_current_client;
 
 #if defined(ENABLE_PLUGINS)
+const char* const kPredefinedAllowedCameraDeviceOrigins[] = {
+  "6EAED1924DB611B6EEF2A664BD077BE7EAD33B8F",  // see crbug.com/383937
+  "4EB74897CB187C7633357C2FE832E0AD6A44883A"   // see crbug.com/383937

[Nico, 2015/02/21 22:24:12]

can we please stop whitelisting random extension ids?

[Justin Chuang, 2015/02/22 12:06:26]

I don't know the whole story. 

Dave, would it help to add Alloy-specific PPAPI permission level (similar to
ppapi::PERMISSION_FLASH)? Or would it be overkill?

[dmichael (off chromium), 2015/02/24 18:24:09]

Sorry, Nico. This is born of wanting to provide APIs for Android-on-Chrome apps
in the most expedient way. This API should probably get on a track to be
available to all extensions. Similar to one Mozilla has:
https://developer.mozilla.org/en-US/docs/Web/API/Camera_API
...probably not acceptable at this point as a web API due to fingerprinting
concerns.

Longer term, we want to start plumbing these kinds of requests as mojo APIs so
that it's hopefully easier to get more sharing across different
languages/runtimes. As it is, there's very little zero shared code between
Pepper and web or chrome.* APIs.
Hmm, I like that idea. I think you could do that as a follow-up if you like.

[Justin Chuang, 2015/02/25 03:59:02]

I can do that only if it's not urgent. I may not be able to return to this
within a month or longer. 

+};
+
 const char* const kPredefinedAllowedCompositorOrigins[] = {
   "6EAED1924DB611B6EEF2A664BD077BE7EAD33B8F",  // see crbug.com/383937
   "4EB74897CB187C7633357C2FE832E0AD6A44883A"   // see crbug.com/383937
 };
 #endif
 
 void AppendParams(const std::vector<base::string16>& additional_names,
                   const std::vector<base::string16>& additional_values,
                   WebVector<WebString>* existing_names,
                   WebVector<WebString>* existing_values) {
@@ skipping 1352 matching lines @@
   chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
   // Allow dev channel APIs to be used on "Canary", "Dev", and "Unknown"
   // releases of Chrome. Permitting "Unknown" allows these APIs to be used on
   // Chromium builds as well.
   return channel <= chrome::VersionInfo::CHANNEL_DEV;
 #else
   return false;
 #endif
 }
 
+bool ChromeContentRendererClient::IsPluginAllowedToUseCameraDeviceAPI(
+    const GURL& url) {
+#if defined(ENABLE_PLUGINS) && defined(ENABLE_EXTENSIONS)
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnablePepperTesting))
+    return true;
+
+  std::set<std::string> allowed_origins;
+  for (size_t i = 0; i < arraysize(kPredefinedAllowedCameraDeviceOrigins); ++i)
+    allowed_origins.insert(kPredefinedAllowedCameraDeviceOrigins[i]);

[Nico, 2015/02/21 23:21:02]

(fwiw, the other whitelists build the set once in the constructor instead of
every time, see lhs in
https://codereview.chromium.org/845823002/diff/40001/chrome/renderer/chrome_c...
. probably good to be self-consistent in this file)

[Justin Chuang, 2015/02/22 12:06:26]

Done.

+  if (IsExtensionOrSharedModuleWhitelisted(url, allowed_origins))
+    return true;
+
+  chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
+  return channel <= chrome::VersionInfo::CHANNEL_DEV;
+#else
+  return false;
+#endif
+}
+
 bool ChromeContentRendererClient::IsPluginAllowedToUseCompositorAPI(
     const GURL& url) {
 #if defined(ENABLE_PLUGINS) && defined(ENABLE_EXTENSIONS)
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnablePepperTesting))
     return true;
   if (IsExtensionOrSharedModuleWhitelisted(url, allowed_compositor_origins_))
     return true;
 
   chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
@@ skipping 12 matching lines @@
   if (mime_type == content::kBrowserPluginMimeType) {
     return new extensions::ExtensionsGuestViewContainer(render_frame);
   } else {
     return new extensions::MimeHandlerViewContainer(
         render_frame, mime_type, original_url);
   }
 #else
   return NULL;
 #endif
 }