Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 943993002: Link to site settings screen from web notifications. (Closed)

Created:
5 years, 10 months ago by Michael van Ouwerkerk
Modified:
5 years, 10 months ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Link to site settings screen from web notifications. Previously, this linked to the notifications settings screen for all sites. BUG=436594 Committed: https://crrev.com/93f4c2482dd19c8303bec5f158fabd041ead14ef Cr-Commit-Position: refs/heads/master@{#317301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 4 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
5 years, 10 months ago (2015-02-20 11:28:57 UTC) #2
Michael van Ouwerkerk
Miguel, could you take a look please?
5 years, 10 months ago (2015-02-20 11:54:14 UTC) #4
Miguel Garcia
lgtm
5 years, 10 months ago (2015-02-20 11:59:17 UTC) #5
Peter Beverloo
lgtm
5 years, 10 months ago (2015-02-20 12:07:14 UTC) #6
Peter Beverloo
Please attach a bug to this CL.
5 years, 10 months ago (2015-02-20 12:07:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943993002/1
5 years, 10 months ago (2015-02-20 12:12:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 12:36:03 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 12:37:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93f4c2482dd19c8303bec5f158fabd041ead14ef
Cr-Commit-Position: refs/heads/master@{#317301}

Powered by Google App Engine
This is Rietveld 408576698