Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: Source/devtools/front_end/promises/PromisePane.js

Issue 943963002: DevTools: Refactor nits in DebuggerModel event dispatching. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @implements {WebInspector.TargetManager.Observer} 8 * @implements {WebInspector.TargetManager.Observer}
9 */ 9 */
10 WebInspector.PromisePane = function() 10 WebInspector.PromisePane = function()
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 var t2 = y.creationTime || 0; 246 var t2 = y.creationTime || 0;
247 return t1 - t2 || x.id - y.id; 247 return t1 - t2 || x.id - y.id;
248 } 248 }
249 }, 249 },
250 250
251 /** 251 /**
252 * @param {!WebInspector.Event} event 252 * @param {!WebInspector.Event} event
253 */ 253 */
254 _onPromiseUpdated: function(event) 254 _onPromiseUpdated: function(event)
255 { 255 {
256 var target = /** @type {!WebInspector.Target} */ (event.data.target); 256 var target = /** @type {!WebInspector.Target} */ (event.target.target()) ;
257 var eventType = /** @type {string} */ (event.data.eventType); 257 var eventType = /** @type {string} */ (event.data.eventType);
258 var details = /** @type {!DebuggerAgent.PromiseDetails} */ (event.data.p romise); 258 var details = /** @type {!DebuggerAgent.PromiseDetails} */ (event.data.p romise);
259 if (eventType === "gc") 259 if (eventType === "gc")
260 details.__isGarbageCollected = true; 260 details.__isGarbageCollected = true;
261 261
262 var promiseIdToDetails = this._promiseDetailsByTarget.get(target); 262 var promiseIdToDetails = this._promiseDetailsByTarget.get(target);
263 if (!promiseIdToDetails) { 263 if (!promiseIdToDetails) {
264 promiseIdToDetails = new Map(); 264 promiseIdToDetails = new Map();
265 this._promiseDetailsByTarget.set(target, promiseIdToDetails) 265 this._promiseDetailsByTarget.set(target, promiseIdToDetails)
266 } 266 }
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 } 660 }
661 }, 661 },
662 662
663 reset: function() 663 reset: function()
664 { 664 {
665 this._hideCollectedPromisesSetting.set(false); 665 this._hideCollectedPromisesSetting.set(false);
666 this._promiseStatusFiltersSetting.set({}); 666 this._promiseStatusFiltersSetting.set({});
667 this._textFilterUI.setValue(""); 667 this._textFilterUI.setValue("");
668 } 668 }
669 } 669 }
OLDNEW
« no previous file with comments | « LayoutTests/inspector/sources/debugger/async-operation-events.html ('k') | Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698