Credential Manager API: add a new "Manage accounts" bubble.

Credential Manager API: add a new "Manage accounts" bubble.

The bubble isn't instantiated yet and the new code is probably completely removed by linker.
See the screenshots in the bug tracker.

BUG=400674
Committed: https://crrev.com/54c2ef8020ab3fe66520b76f6c95ba8010a5cfc1
Cr-Commit-Position: refs/heads/master@{#317348}

[vasilii, 2015-02-20 16:14:46]

vasilii@chromium.org changed reviewers:
+ mkwst@chromium.org

[vasilii, 2015-02-20 16:14:47]

Hi Mike,

please review.

[Mike West, 2015-02-20 16:21:39]

LGTM % nits.

I don't understand why we need the request context, but we can fiddle with that
in a future CL, as it effects existing code.

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_credential_item_view.cc (right):

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_credential_item_view.cc:108: //
TODO(vasilii): notify |model_|.
Nit: about the deletion? In the destructor, I suppose?

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_credential_item_view.h (right):

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_credential_item_view.h:38:
net::URLRequestContextGetter* request_context);
Why do we need the request context? Seems strange.

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:726: for
(auto* form : parent_->model()->local_pending_credentials()) {
Nit: This is just `autofill::PasswordForm*`, right? If so, let's just use that
instead of auto.

[vasilii, 2015-02-20 16:56:32]

New patchsets have been uploaded after l-g-t-m from mkwst@chromium.org

[vasilii, 2015-02-20 16:58:51]

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_credential_item_view.cc (right):

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_credential_item_view.cc:108: //
TODO(vasilii): notify |model_|.
On 2015/02/20 16:21:39, Mike West wrote:
> Nit: about the deletion? In the destructor, I suppose?

Actually, no. When you press "delete" in the classic bubble, we remove the
PasswordForm immediately.

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_credential_item_view.h (right):

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_credential_item_view.h:38:
net::URLRequestContextGetter* request_context);
On 2015/02/20 16:21:39, Mike West wrote:
> Why do we need the request context? Seems strange.

It's for requesting an avatar. I removed this parameter because we can extract
it from |model| directly.

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/943933004/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:726: for
(auto* form : parent_->model()->local_pending_credentials()) {
On 2015/02/20 16:21:39, Mike West wrote:
> Nit: This is just `autofill::PasswordForm*`, right? If so, let's just use that
> instead of auto.

Done.

[vasilii, 2015-02-20 16:59:17]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2015-02-20 17:00:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/943933004/20001

[commit-bot: I haz the power, 2015-02-20 18:03:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 18:04:21]

Patchset 2 (id:??) landed as
https://crrev.com/54c2ef8020ab3fe66520b76f6c95ba8010a5cfc1
Cr-Commit-Position: refs/heads/master@{#317348}