Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 943923003: Removing the isolate.py functionality and requiring tasks to be created from an archive hash rather… (Closed)

Created:
5 years, 10 months ago by Mike Meade
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing the isolate.py functionality and requiring tasks to be created from an archive hash rather than an isolate file. Also adding back the controller_test.py and isolate files which were missed in the refactor cl due to a bad move. The only change to these files are to support isolate hashes rather than isolate files. BUG=460340 Committed: https://crrev.com/062b5642c4199a8ddc882c8ae06a794d211c0bf9 Cr-Commit-Position: refs/heads/master@{#317703}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Changing a little terminology and adding functionality for custom task names to help in identifying… #

Patch Set 4 : Doing a little clean up #

Total comments: 4

Patch Set 5 : Fixing a small style issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -31 lines) Patch
A + testing/legion/examples/hello_world/controller_test.isolate View 1 1 chunk +2 lines, -3 lines 0 comments Download
A testing/legion/examples/hello_world/controller_test.py View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
M testing/legion/examples/subprocess/subprocess_test.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
M testing/legion/examples/subprocess/subprocess_test.py View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M testing/legion/task_controller.py View 1 2 3 4 4 chunks +9 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mike Meade
5 years, 10 months ago (2015-02-20 22:04:14 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/943923003/diff/60001/testing/legion/examples/hello_world/controller_test.py File testing/legion/examples/hello_world/controller_test.py (right): https://codereview.chromium.org/943923003/diff/60001/testing/legion/examples/hello_world/controller_test.py#newcode54 testing/legion/examples/hello_world/controller_test.py:54: self.task2 = self.CreateTask(args.task_hash) Didn't you want to use ...
5 years, 10 months ago (2015-02-23 23:17:07 UTC) #4
Mike Meade
https://codereview.chromium.org/943923003/diff/60001/testing/legion/examples/hello_world/controller_test.py File testing/legion/examples/hello_world/controller_test.py (right): https://codereview.chromium.org/943923003/diff/60001/testing/legion/examples/hello_world/controller_test.py#newcode54 testing/legion/examples/hello_world/controller_test.py:54: self.task2 = self.CreateTask(args.task_hash) On 2015/02/23 23:17:07, M-A Ruel wrote: ...
5 years, 10 months ago (2015-02-23 23:22:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943923003/80001
5 years, 10 months ago (2015-02-23 23:33:27 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-24 01:00:29 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:01:17 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/062b5642c4199a8ddc882c8ae06a794d211c0bf9
Cr-Commit-Position: refs/heads/master@{#317703}

Powered by Google App Engine
This is Rietveld 408576698