Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 943903002: Pass MediaLog to CreateMediaRendererFactory (Closed)

Created:
5 years, 10 months ago by servolk
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, lcwu+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass MediaLog to CreateMediaRendererFactory This will allow custom media renderers to instantiate default renderer factory, which expects media log. BUG=457959 Committed: https://crrev.com/04b667817aed5d9c54dd09194f81149828c69659 Cr-Commit-Position: refs/heads/master@{#317359}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Pass medialog smart pointer by const reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chromecast/renderer/cast_content_renderer_client.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
servolk
5 years, 10 months ago (2015-02-20 01:50:52 UTC) #3
gunsch
On 2015/02/20 01:50:52, servolk wrote: chromecast/ lgtm
5 years, 10 months ago (2015-02-20 02:09:57 UTC) #4
DaleCurtis
lgtm % nit https://codereview.chromium.org/943903002/diff/1/chromecast/renderer/cast_content_renderer_client.cc File chromecast/renderer/cast_content_renderer_client.cc (right): https://codereview.chromium.org/943903002/diff/1/chromecast/renderer/cast_content_renderer_client.cc#newcode144 chromecast/renderer/cast_content_renderer_client.cc:144: scoped_refptr<media::MediaLog> media_log) { const & here ...
5 years, 10 months ago (2015-02-20 03:18:33 UTC) #5
servolk
On 2015/02/20 03:18:33, DaleCurtis wrote: > lgtm % nit > > https://codereview.chromium.org/943903002/diff/1/chromecast/renderer/cast_content_renderer_client.cc > File chromecast/renderer/cast_content_renderer_client.cc ...
5 years, 10 months ago (2015-02-20 03:29:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943903002/20001
5 years, 10 months ago (2015-02-20 03:35:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44100)
5 years, 10 months ago (2015-02-20 03:41:19 UTC) #11
servolk
On 2015/02/20 03:41:19, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-20 03:48:32 UTC) #13
jam
lgtm
5 years, 10 months ago (2015-02-20 16:25:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943903002/20001
5 years, 10 months ago (2015-02-20 18:41:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 18:45:04 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 18:45:36 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04b667817aed5d9c54dd09194f81149828c69659
Cr-Commit-Position: refs/heads/master@{#317359}

Powered by Google App Engine
This is Rietveld 408576698