win vs2015: disable some warnings in non-chromium code, change magic maxilksize

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 3016 matching lines @@
               '-Wno-unused-result',
             ],
           }],
           [ 'OS=="win"', {
             'defines': [
               '_CRT_SECURE_NO_DEPRECATE',
               '_CRT_NONSTDC_NO_WARNINGS',
               '_CRT_NONSTDC_NO_DEPRECATE',
               '_SCL_SECURE_NO_DEPRECATE',
             ],
-            'msvs_disabled_warnings': [4800],
+            'msvs_disabled_warnings': [
+              # These are variable shadowing warnings that are new in VS2015.
+              # We should probably work through these at some point for
+              # non-chromium code, but for now, focus on chromium_code==1 code.
+              4456, 4457, 4458, 4459,
+
+              4800,
+            ],
             'msvs_settings': {
               'VCCLCompilerTool': {
                 'WarningLevel': '3',
                 'WarnAsError': 'true',
                 'Detect64BitPortabilityProblems': 'false',
               },
             },
             'conditions': [
               ['buildtype=="Official"', {
                 'msvs_settings': {
@@ skipping 101 matching lines @@
               'odbc32.lib',
               'odbccp32.lib',
               'delayimp.lib',
               'credui.lib',
               'netapi32.lib',
             ],
             'AdditionalOptions': [
               # Suggested by Microsoft Devrel to avoid
               #   LINK : fatal error LNK1248: image size (80000000) exceeds maximum allowable size (80000000)
               # which started happening more regularly after VS2013 Update 4.
-              '/maxilksize:2147483647',
+              # Needs to be a bit lower for VS2015, or else errors out.
+              '/maxilksize:0x7ff00000',

[brucedawson, 2015/02/20 18:09:03]

Good. I hit the same error in some VS 2013 context (which I can't recall the
details of) and lowering to 0x7ff00000 should resolve that issue as well.

             ],
           },
         },
       },
       'x86_Base': {
         'abstract': 1,
         'msvs_settings': {
           'VCLinkerTool': {
             'MinimumRequiredVersion': '5.01',  # XP.
             'TargetMachine': '1',
@@ skipping 2212 matching lines @@
           }],
         ],
         'msvs_system_include_dirs': [
           '<(windows_sdk_path)/Include/shared',
           '<(windows_sdk_path)/Include/um',
           '<(windows_sdk_path)/Include/winrt',
           '$(VSInstallDir)/VC/atlmfc/include',
         ],
         'msvs_cygwin_shell': 0,
         'msvs_disabled_warnings': [
+          # C4091: 'typedef ': ignored on left of 'X' when no variable is
+          #                    declared.
+          # This happens in a number of Windows headers. Dumb.
+          4091,
+
           # C4127: conditional expression is constant
           # This warning can in theory catch dead code and other problems, but
           # triggers in far too many desirable cases where the conditional
           # expression is either set by macros or corresponds some legitimate
           # compile-time constant expression (due to constant template args,
           # conditionals comparing the sizes of different types, etc.).  Some of
           # these can be worked around, but it's not worth it.
           4127,
 
           # C4351: new behavior: elements of array 'array' will be default
@@ skipping 516 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }