Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 943783003: Pad HID output reports on Windows to the maximum output report size. (Closed)

Created:
5 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pad HID output reports on Windows to the maximum output report size. The Windows HID library requires output report buffers to be exactly the maximum length specified in the OutputReportByteLength field of HIDP_CAPS. This patch automatically pads output reports to this length with zeros and rejects reports longer than this length. BUG=439775 Committed: https://crrev.com/c591ca06d74bbba47bae030217a6a8de826bef40 Cr-Commit-Position: refs/heads/master@{#317393}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added "size" to comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M device/hid/hid_connection.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M device/hid/hid_connection_win.cc View 1 1 chunk +13 lines, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/api_test/hid/api/background.js View 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Hey man, please take a look!
5 years, 10 months ago (2015-02-20 01:38:47 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/943783003/diff/1/device/hid/hid_connection_win.cc File device/hid/hid_connection_win.cc (right): https://codereview.chromium.org/943783003/diff/1/device/hid/hid_connection_win.cc#newcode143 device/hid/hid_connection_win.cc:143: // the front of every output report and ...
5 years, 10 months ago (2015-02-20 02:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943783003/20001
5 years, 10 months ago (2015-02-20 19:01:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 20:42:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:43:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c591ca06d74bbba47bae030217a6a8de826bef40
Cr-Commit-Position: refs/heads/master@{#317393}

Powered by Google App Engine
This is Rietveld 408576698