Issue 943783002: Add test for PDF's JS "global".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943783002: Add test for PDF's JS "global". (Closed)

Created:
5 years, 10 months ago by Tom Sepez

Modified:
5 years, 10 months ago

Reviewers:
jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add test for PDF's JS "global". Exercises a separate code path that stores some JS objects outside of JS. Needed before re-writing some other portions of the JS_Defines.h code. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dce5730e8335749734a3195d16e247c40d6fef3e

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -0 lines)			Patch
	A	testing/resources/javascript/globals.in	View		1 chunk	+137 lines, -0 lines	0 comments	Download
	A	testing/resources/javascript/globals_expected.txt	View		1 chunk	+105 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 10 months ago (2015-02-19 23:58:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dce5730e8335749734a3195d16e247c40d6fef3e (presubmit successful).