Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 943773003: Updating gyp repo for git, preparing for cq. (Closed)

Created:
5 years, 10 months ago by bradn
Modified:
5 years, 10 months ago
Reviewers:
iannucci, scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Updating gyp repo for git, preparing for cq. Switching source URL in codereview settings. Adding commit_queue json in preparation for a gyp CQ. BUG=None TEST=None R=scottmg@chromium.org, iannucci@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/7cd6018356361f881f79a1d2595a51cf8c225700

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : fix #

Total comments: 4

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M PRESUBMIT.py View 1 2 3 4 5 1 chunk +13 lines, -2 lines 0 comments Download
A buildbot/commit_queue/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A buildbot/commit_queue/README View 1 chunk +3 lines, -0 lines 0 comments Download
A buildbot/commit_queue/cq_config.json View 1 chunk +16 lines, -0 lines 0 comments Download
M codereview.settings View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
5 years, 10 months ago (2015-02-20 00:20:40 UTC) #1
scottmg
https://codereview.chromium.org/943773003/diff/80001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/943773003/diff/80001/PRESUBMIT.py#newcode130 PRESUBMIT.py:130: 'gyp-win8', i think remove this one? https://codereview.chromium.org/943773003/diff/80001/buildbot/commit_queue/cq_config.json File buildbot/commit_queue/cq_config.json ...
5 years, 10 months ago (2015-02-20 00:22:30 UTC) #3
bradn
https://codereview.chromium.org/943773003/diff/80001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/943773003/diff/80001/PRESUBMIT.py#newcode130 PRESUBMIT.py:130: 'gyp-win8', On 2015/02/20 00:22:30, scottmg wrote: > i think ...
5 years, 10 months ago (2015-02-20 00:27:56 UTC) #4
scottmg
lgtm insofar as I know anything. Which I don't. :)
5 years, 10 months ago (2015-02-20 00:31:22 UTC) #5
bradn
5 years, 10 months ago (2015-02-20 00:42:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
7cd6018356361f881f79a1d2595a51cf8c225700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698