Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 943643002: Pull up get{User,}BookmarkId from ChromeTab to Tab. (Closed)

Created:
5 years, 10 months ago by Yaron
Modified:
5 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull up get{User,}BookmarkId from ChromeTab to Tab. It's possible that this could move to BookmarksBridge but it would require some more refactoring so start with just upstreaming. BUG=443773 Committed: https://crrev.com/081765c8b5103397acf81ec03e61d6b2a0250b10 Cr-Commit-Position: refs/heads/master@{#317087}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yaron
5 years, 10 months ago (2015-02-19 15:07:33 UTC) #2
gone
lgtm https://chromiumcodereview.appspot.com/943643002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://chromiumcodereview.appspot.com/943643002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode2365 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:2365: * exists). indentation's wonky.
5 years, 10 months ago (2015-02-19 18:08:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943643002/20001
5 years, 10 months ago (2015-02-19 18:14:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 19:07:06 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:07:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/081765c8b5103397acf81ec03e61d6b2a0250b10
Cr-Commit-Position: refs/heads/master@{#317087}

Powered by Google App Engine
This is Rietveld 408576698