[WebView] Remove onFailure from VisualStateCallback.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 184 matching lines @@
     GetSiteInstance()->decrement_active_frame_count();
 
   // Notify the FrameTree that this RFH is going away, allowing it to shut down
   // the corresponding RenderViewHost if it is no longer needed.
   frame_tree_->UnregisterRenderFrameHost(this);
 
   // NULL out the swapout timer; in crash dumps this member will be null only if
   // the dtor has run.
   swapout_event_monitor_timeout_.reset();
 
-  for (const auto& iter: visual_state_callbacks_) {
-    iter.second.Run(false);
-  }

[boliu, 2015/02/19 18:43:41]

There's a bit inconsistent between renderer and browser shutdown.

In renderer shutdown, all the callback still fire (with COMMIT_FAILS). But now
if browser is shutdown first, all the callbacks are just ignored.

How about keep this block, so at least the content layer guarantees these
callbacks runs no matter what, and it's up for android_webview to decide what to
do in those cases.

[Ignacio Solla, 2015/02/20 11:10:41]

Thanks, good catch. 

So how about do not deliver the callback if the renderer is shuting down? I
think I prefer that option so that the content layer guarantees that these
callbacks only run when the contents are ready. Do you agree? I'm happy to
change it to whatever you want though.

[boliu, 2015/02/20 16:50:55]

+piman to decide

I like hard guarantees over silent "failures". Also I think SwapPromise is used
for other features not related to webview, and I don't know what requirements
those features have about this.

[Ignacio Solla, 2015/02/24 12:49:35]

Done.

-
   if (render_widget_host_)
     render_widget_host_->Cleanup();
 }
 
 int RenderFrameHostImpl::GetRoutingID() {
   return routing_id_;
 }
 
 SiteInstanceImpl* RenderFrameHostImpl::GetSiteInstance() {
   return site_instance_.get();
@@ skipping 901 matching lines @@
     it->second.Run(result_value);
     javascript_callbacks_.erase(it);
   } else {
     NOTREACHED() << "Received script response for unknown request";
   }
 }
 
 void RenderFrameHostImpl::OnVisualStateResponse(uint64 id) {
   auto it = visual_state_callbacks_.find(id);
   if (it != visual_state_callbacks_.end()) {
-    it->second.Run(true);
+    it->second.Run();
     visual_state_callbacks_.erase(it);
   } else {
     NOTREACHED() << "Received script response for unknown request";
   }
 }
 
 void RenderFrameHostImpl::OnRunJavaScriptMessage(
     const base::string16& message,
     const base::string16& default_prompt,
     const GURL& frame_url,
@@ skipping 745 matching lines @@
 void RenderFrameHostImpl::DidUseGeolocationPermission() {
   RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame();
   GetContentClient()->browser()->RegisterPermissionUsage(
       PERMISSION_GEOLOCATION,
       delegate_->GetAsWebContents(),
       GetLastCommittedURL().GetOrigin(),
       top_frame->GetLastCommittedURL().GetOrigin());
 }
 
 }  // namespace content