Issue 943623002: Do not clear the source device in SkGpuDevice::drawDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943623002: Do not clear the source device in SkGpuDevice::drawDevice (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen

Modified:
5 years, 10 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Do not clear the source device in SkGpuDevice::drawDevice Do not clear the source device in SkGpuDevice::drawDevice based on the status whether the destination device needs a clear. Source device clear is flushed in SkGpuDevice::accessRenderTarget() and target device clear is flushed in CHECK_SHOULD_DRAW(draw). Committed: https://skia.googlesource.com/skia/+/2e4414e60b1f98e1736aa1925cbe181ed37d11e8

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/gpu/SkGpuDevice.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kimmo Kinnunen

Probably a search-replace error in : https://codereview.chromium.org/848903004 ?

5 years, 10 months ago (2015-02-19 14:49:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943623002/20001

5 years, 10 months ago (2015-02-19 15:01:54 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 15:20:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2e4414e60b1f98e1736aa1925cbe181ed37d11e8

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages