Issue 943573002: Minor tools/grokdump improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943573002: Minor tools/grokdump improvements (Closed)

Created:
5 years, 10 months ago by Igor Sheludko

Modified:
5 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Minor tools/grokdump improvements: avoid some None dereferences and add some line breaks to generated html pages. Committed: https://crrev.com/ab641509567a2ecad57e956849095c9b8123746f Cr-Commit-Position: refs/heads/master@{#26752}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	tools/grokdump.py	View		4 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943573002/1

5 years, 10 months ago (2015-02-19 14:15:28 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 14:36:36 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ab641509567a2ecad57e956849095c9b8123746f
Cr-Commit-Position: refs/heads/master@{#26752}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages