Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: src/parser.h

Issue 943543002: [strong] Declaration-after-use errors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: more fixes + tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index bc0b7ab51b0546257d807260331c540098d6d133..ad6e07701e05495e2b8ef88278acd7c630d13c9b 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -8,6 +8,7 @@
#include "src/allocation.h"
#include "src/ast.h"
#include "src/compiler.h" // For CachedDataMode
+#include "src/pending-compilation-error-handler.h"
#include "src/preparse-data.h"
#include "src/preparse-data-format.h"
#include "src/preparser.h"
@@ -541,7 +542,8 @@ class ParserTraits {
int end_pos);
Literal* ExpressionFromLiteral(Token::Value token, int pos, Scanner* scanner,
AstNodeFactory* factory);
- Expression* ExpressionFromIdentifier(const AstRawString* name, int pos,
+ Expression* ExpressionFromIdentifier(const AstRawString* name,
+ int start_position, int end_position,
Scope* scope, AstNodeFactory* factory);
Expression* ExpressionFromString(int pos, Scanner* scanner,
AstNodeFactory* factory);
@@ -843,13 +845,7 @@ class Parser : public ParserBase<ParserTraits> {
bool parsing_lazy_arrow_parameters_; // for lazily parsed arrow functions.
- // Pending errors.
- bool has_pending_error_;
- Scanner::Location pending_error_location_;
- const char* pending_error_message_;
- const AstRawString* pending_error_arg_;
- const char* pending_error_char_arg_;
- ParseErrorType pending_error_type_;
+ PendingCompilationErrorHandler pending_error_handler_;
// Other information which will be stored in Parser and moved to Isolate after
// parsing.

Powered by Google App Engine
This is Rietveld 408576698