Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 943483002: [turbofan] Fix typing of comparisons. (Closed)

Created:
5 years, 10 months ago by Jarin
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
rossberg, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing of comparisons. BUG=chromium:459955 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/9951e1e5f0a7259ca2c07fb616dc907f7e4a23f7 Cr-Commit-Position: refs/heads/master@{#26743}

Patch Set 1 #

Patch Set 2 : Test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -21 lines) Patch
M src/compiler/typer.cc View 5 chunks +58 lines, -16 lines 2 comments Download
A + test/mjsunit/regress/regress-459955.js View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jarin
Could you take a look, please?
5 years, 10 months ago (2015-02-19 10:26:18 UTC) #1
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/943483002/diff/20001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/943483002/diff/20001/src/compiler/typer.cc#newcode334 src/compiler/typer.cc:334: typedef base::Flags<ComparisonOutcomeFlags> ComparisonOutcome; You should also ...
5 years, 10 months ago (2015-02-19 10:32:57 UTC) #2
Jarin
https://codereview.chromium.org/943483002/diff/20001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/943483002/diff/20001/src/compiler/typer.cc#newcode334 src/compiler/typer.cc:334: typedef base::Flags<ComparisonOutcomeFlags> ComparisonOutcome; On 2015/02/19 10:32:57, Benedikt Meurer wrote: ...
5 years, 10 months ago (2015-02-19 10:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943483002/20001
5 years, 10 months ago (2015-02-19 10:51:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 10:56:22 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 10:56:35 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9951e1e5f0a7259ca2c07fb616dc907f7e4a23f7
Cr-Commit-Position: refs/heads/master@{#26743}

Powered by Google App Engine
This is Rietveld 408576698