Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 943473002: Dispatch directory-changed event before rescan starts. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dispatch directory-changed event before rescan starts. Directory rescan sometimes uses up IO and blocks other IOs which are necessary for updating the top-left breadcrumb. While this CL does not solve the real cause of the issue, this CL mitigates the problem by dispatching event earlier. BUG=459864 TEST=manually tested as described in the issue Committed: https://crrev.com/3027da7aee006ad04e084690d6ea410a31969728 Cr-Commit-Position: refs/heads/master@{#317021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-19 10:03:48 UTC) #2
fukino
On 2015/02/19 10:03:48, yawano wrote: > PTAL. Thank you! lgtm.
5 years, 10 months ago (2015-02-19 10:09:00 UTC) #3
yawano
On 2015/02/19 10:09:00, fukino wrote: > On 2015/02/19 10:03:48, yawano wrote: > > PTAL. Thank ...
5 years, 10 months ago (2015-02-19 10:09:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943473002/1
5 years, 10 months ago (2015-02-19 10:10:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 10:31:29 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3027da7aee006ad04e084690d6ea410a31969728 Cr-Commit-Position: refs/heads/master@{#317021}
5 years, 10 months ago (2015-02-19 10:32:21 UTC) #8
yawano
5 years, 10 months ago (2015-02-20 07:27:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/937423002/ by yawano@chromium.org.

The reason for reverting is: This CL broke as described in
http://crbug.com/460398.
This issue is going to be fixed in different way with another CL..

Powered by Google App Engine
This is Rietveld 408576698