LayoutTests/css-parser/font-size-adjust.html - Issue 943463002: Initial implementation of font-size-adjust

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css-parser/font-size-adjust.html

Issue 943463002: Initial implementation of font-size-adjust (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: UpdatedPatch Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/js-test.js"></script>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="resources/property-parsing-test.js"></script>

	6 <script>

	7 description('Verifies that font-size-adjust property and its value are properly parsed.');

	8

	9 assert_valid_value("fontSizeAdjust", "1.5");

	10 assert_valid_value("fontSizeAdjust", "0.5");

	11 assert_valid_value("fontSizeAdjust", "0");
	rune 2015/03/03 18:58:48 I think 0 should be allowed, but IIRC, Gecko drops I think 0 should be allowed, but IIRC, Gecko drops it. But, since you represent 'none' as 0 internally, won't this be interpreted as 'none'? changseok 2015/03/03 19:39:41 Gecko doesn't drop 0 and it interprets 0 as none i Show quoted text On 2015/03/03 18:58:48, rune wrote: > I think 0 should be allowed, but IIRC, Gecko drops it. But, since you represent > 'none' as 0 internally, won't this be interpreted as 'none'? Gecko doesn't drop 0 and it interprets 0 as none internally for the computed style of font-size-adjust as you said. Current implementation shows exactly same behavior with that of Gecko. =) You can try it in http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_style_fontsizeadjust
	12 assert_valid_value("fontSizeAdjust", "none");

	13 assert_invalid_value("fontSizeAdjust", "-0.5");

	14 assert_invalid_value("fontSizeAdjust", "-1.5");

	15 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/css-parser/font-size-adjust-expected.txt » ('j') | no next file with comments »