Add tooltips to profile name when truncated

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #import <Carbon/Carbon.h>  // kVK_Return.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
@@ skipping 683 matching lines @@
       [profileNameTextField_ setTarget:self];
       [profileNameTextField_ setAction:@selector(saveProfileName:)];
 
       // Hide the textfield until the user clicks on the button.
       [profileNameTextField_ setHidden:YES];
 
       [[self cell] accessibilitySetOverrideValue:l10n_util::GetNSStringF(
           IDS_PROFILES_NEW_AVATAR_MENU_EDIT_NAME_ACCESSIBLE_NAME,
           base::SysNSStringToUTF16(profileName))
                                     forAttribute:NSAccessibilityTitleAttribute];
+
+      NSSize textSize = [profileName sizeWithAttributes:
+          @{NSFontAttributeName: [profileNameTextField_ font]}];
+
+      if (textSize.width > frameRect.size.width - [hoverImage size].width * 2) {

[noms (inactive), 2015/02/23 22:16:34]

nit: no {}, only 2 spaces indent on the second line

[wesleylancel, 2015/02/23 22:45:47]

Done.

+          [self setToolTip:profileName];
+      }
     }
 
     [[self cell] accessibilitySetOverrideValue:NSAccessibilityButtonRole
                                   forAttribute:NSAccessibilityRoleAttribute];
     [[self cell]
         accessibilitySetOverrideValue:NSAccessibilityRoleDescription(
                                           NSAccessibilityButtonRole, nil)
                          forAttribute:NSAccessibilityRoleDescriptionAttribute];
 
     [self setBordered:NO];
@@ skipping 1084 matching lines @@
 
   [profileButton setDefaultImage:CreateProfileImage(
       itemIcon, kSmallImageSide).ToNSImage()];
   [profileButton setImagePosition:NSImageLeft];
   [profileButton setAlignment:NSLeftTextAlignment];
   [profileButton setBordered:NO];
   [profileButton setTag:itemIndex];
   [profileButton setTarget:self];
   [profileButton setAction:@selector(switchToProfile:)];
 
+  NSSize textSize = [[profileButton title] sizeWithAttributes:
+      @{NSFontAttributeName: [profileButton font]}];
+
+  if (lroundf(textSize.width) >
+      rect.size.width - kSmallImageSide -

[noms (inactive), 2015/02/23 22:16:34]

nit: move the thing on the right hand side of the > to its own local variable.
it's pretty unreadable :)

[wesleylancel, 2015/02/23 22:45:47]

Done.

+      kImageTitleSpacing - kHorizontalSpacing) {
+      [profileButton setToolTip:[profileButton title]];

[noms (inactive), 2015/02/23 22:16:34]

nit: only indent 2 spaces

[wesleylancel, 2015/02/23 22:45:48]

Done.

+  }
+
   return profileButton.autorelease();
 }
 
 - (NSView*)createOptionsViewWithRect:(NSRect)rect
                          displayLock:(BOOL)displayLock {
   NSRect viewRect = NSMakeRect(0, 0,
                                rect.size.width,
                                kBlueButtonHeight + kSmallVerticalSpacing);
   base::scoped_nsobject<NSView> container([[NSView alloc] initWithFrame:rect]);
 
@@ skipping 466 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end