Add tooltips to profile name when truncated

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #import <Carbon/Carbon.h>  // kVK_Return.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
@@ skipping 683 matching lines @@
       [profileNameTextField_ setTarget:self];
       [profileNameTextField_ setAction:@selector(saveProfileName:)];
 
       // Hide the textfield until the user clicks on the button.
       [profileNameTextField_ setHidden:YES];
 
       [[self cell] accessibilitySetOverrideValue:l10n_util::GetNSStringF(
           IDS_PROFILES_NEW_AVATAR_MENU_EDIT_NAME_ACCESSIBLE_NAME,
           base::SysNSStringToUTF16(profileName))
                                     forAttribute:NSAccessibilityTitleAttribute];
+

[groby-ooo-7-16, 2015/02/19 19:00:10]

Question: Why not allow expansion tooltips on |profileNameTextField_| instead?
(I assume the containing control intercepts those, but I want to make sure we
can't do that)

+      NSSize textSize = [profileName sizeWithAttributes:
+          @{NSFontAttributeName: [NSFont labelFontOfSize:kTitleFontSize]}];

[groby-ooo-7-16, 2015/02/19 19:00:10]

[profileNameTextField_ font] instead, please.

+
+      if (textSize.width > frameRect.size.width - [hoverImage size].width * 2) {

[groby-ooo-7-16, 2015/02/19 19:00:10]

... > NSWidth(frameRect)

(We're usually avoiding reaching into NSRect members, if we can)

+          [self setToolTip:profileName];
+      }
     }
 
     [[self cell] accessibilitySetOverrideValue:NSAccessibilityButtonRole
                                   forAttribute:NSAccessibilityRoleAttribute];
     [[self cell]
         accessibilitySetOverrideValue:NSAccessibilityRoleDescription(
                                           NSAccessibilityButtonRole, nil)
                          forAttribute:NSAccessibilityRoleDescriptionAttribute];
 
     [self setBordered:NO];
@@ skipping 1570 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end