tools/render_pictures_main.cpp - Issue 943453002: Avoid wrong memory access due to double substitution and %%

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/render_pictures_main.cpp

Issue 943453002: Avoid wrong memory access due to double substitution and %% (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/render_pictures_main.cpp

diff --git a/tools/render_pictures_main.cpp b/tools/render_pictures_main.cpp

index 11c640fdc2c6c6995a8a0ed1a16440fa488c5515..16963dd3cf717478816e13ddb8e1a04ed48a8a73 100644

--- a/tools/render_pictures_main.cpp

+++ b/tools/render_pictures_main.cpp

@@ -399,7 +399,7 @@ static int process_input(const char* input, const SkString* writePath,

} else {

SkString warning;

warning.printf("Warning: skipping %s\n", input);

- SkDebugf(warning.c_str());

+ SkDebugf("%s", warning.c_str());

}

return failures;

}

« no previous file with comments | « tests/skia_test.cpp ('k') | no next file » | no next file with comments »