tests/PathOpsSkpClipTest.cpp - Issue 943453002: Avoid wrong memory access due to double substitution and %%

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/PathOpsSkpClipTest.cpp

Issue 943453002: Avoid wrong memory access due to double substitution and %% (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #include "CrashHandler.h"	1 #include "CrashHandler.h"

2 // #include "OverwriteLine.h"	2 // #include "OverwriteLine.h"

3 #include "Resources.h"	3 #include "Resources.h"

4 #include "SkBitmap.h"	4 #include "SkBitmap.h"

5 #include "SkCanvas.h"	5 #include "SkCanvas.h"

6 #include "SkColor.h"	6 #include "SkColor.h"

7 #include "SkColorPriv.h"	7 #include "SkColorPriv.h"

8 #include "SkCommandLineFlags.h"	8 #include "SkCommandLineFlags.h"

9 #include "SkDevice.h"	9 #include "SkDevice.h"

10 #include "SkForceLinking.h"	10 #include "SkForceLinking.h"

(...skipping 1068 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1079 }	1079 }

1080 #ifdef SK_DEBUG	1080 #ifdef SK_DEBUG

1081 header.append(" SK_DEBUG");	1081 header.append(" SK_DEBUG");

1082 #else	1082 #else

1083 header.append(" SK_RELEASE");	1083 header.append(" SK_RELEASE");

1084 #endif	1084 #endif

1085 header.appendf(" skia_arch_width=%d", (int)sizeof(void) 8);	1085 header.appendf(" skia_arch_width=%d", (int)sizeof(void) 8);

1086 if (FLAGS_verbose) {	1086 if (FLAGS_verbose) {

1087 header.appendf("\n");	1087 header.appendf("\n");

1088 }	1088 }

1089 SkDebugf(header.c_str());	1089 SkDebugf("%s", header.c_str());

1090 Iter iter;	1090 Iter iter;

1091 Test* test;	1091 Test* test;

1092 while ((test = iter.next()) != NULL) {	1092 while ((test = iter.next()) != NULL) {

1093 SkAutoTDelete<Test> owned(test);	1093 SkAutoTDelete<Test> owned(test);

1094 if (!SkCommandLineFlags::ShouldSkip(FLAGS_match, test->getName())) {	1094 if (!SkCommandLineFlags::ShouldSkip(FLAGS_match, test->getName())) {

1095 test->run();	1095 test->run();

1096 }	1096 }

1097 }	1097 }

1098 SkGraphics::Term();	1098 SkGraphics::Term();

1099 return 0;	1099 return 0;

1100 }	1100 }

1101	1101

1102 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)	1102 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)

1103 int main(int argc, char * const argv[]) {	1103 int main(int argc, char * const argv[]) {

1104 return tool_main(argc, (char**) argv);	1104 return tool_main(argc, (char**) argv);

1105 }	1105 }

1106 #endif	1106 #endif

OLD	NEW

« no previous file with comments | « tests/PathOpsExtendedTest.cpp ('k') | tests/skia_test.cpp » ('j') | no next file with comments »