Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 943423002: SkStream: Add SkDynamicMemoryWStream::writeToStream(SkWStream*) (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkStream: Add SkDynamicMemoryWStream::writeToStream(SkWStream*) Committed: https://skia.googlesource.com/skia/+/7af21501a61886cac94f0bd5e1c14be2dce9ae63

Patch Set 1 #

Patch Set 2 : 2015-02-23 (Monday) 12:24:26 EST #

Patch Set 3 : 2015-02-23 (Monday) 13:35:18 EST #

Patch Set 4 : 2015-02-23 (Monday) 15:03:08 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M include/core/SkStream.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkStream.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pdf/SkPDFUtils.cpp View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hal.canary
PTAL
5 years, 10 months ago (2015-02-23 17:04:03 UTC) #2
hal.canary
Adding reed@ for API change.
5 years, 10 months ago (2015-02-23 17:25:56 UTC) #4
bungeman-skia
lgtm
5 years, 10 months ago (2015-02-23 17:27:06 UTC) #5
reed1
lgtm
5 years, 10 months ago (2015-02-23 19:41:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943423002/40001
5 years, 10 months ago (2015-02-23 19:42:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/2275)
5 years, 10 months ago (2015-02-23 19:43:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943423002/60001
5 years, 10 months ago (2015-02-23 20:04:10 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:18:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7af21501a61886cac94f0bd5e1c14be2dce9ae63

Powered by Google App Engine
This is Rietveld 408576698