DM: lazy decoding on SKP playback

DM: lazy decoding on SKP playback

Command `out/Release/dm --config pdf --src gm skp`, uses 27% less RAM.

Committed: https://skia.googlesource.com/skia/+/77d366d72a6ae83fb0abcb2ec7e2d692fef2e923

[hal.canary, 2015-02-23 16:05:36]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-02-23 16:05:37]

ptal

[mtklein, 2015-02-23 17:01:11]

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp#newcode15
dm/DMSrcSink.cpp:15: 
Move here?

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp#newcode114
dm/DMSrcSink.cpp:114: bool lazy_decode_bitmap(const void* src, size_t size,
SkBitmap* dst) {
static instead?

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp#newcode390
dm/DMSrcSink.cpp:390: SkAutoTUnref<SkPicture>
deserialized(SkPicture::CreateFromStream(rStream));
Let's move lazy_decode_bitmap up to the very top (marked) and use it here too? 
My local testing seems to be saving 100-200MB peak on a run like dm --config
serialize-8888  --src gm skp

[hal.canary, 2015-02-23 18:16:36]

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp#newcode15
dm/DMSrcSink.cpp:15: 
On 2015/02/23 17:01:10, mtklein wrote:
> Move here?

Done.

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp#newcode114
dm/DMSrcSink.cpp:114: bool lazy_decode_bitmap(const void* src, size_t size,
SkBitmap* dst) {
On 2015/02/23 17:01:10, mtklein wrote:
> static instead?

Done.

https://codereview.chromium.org/943383002/diff/40001/dm/DMSrcSink.cpp#newcode390
dm/DMSrcSink.cpp:390: SkAutoTUnref<SkPicture>
deserialized(SkPicture::CreateFromStream(rStream));
On 2015/02/23 17:01:10, mtklein wrote:
> Let's move lazy_decode_bitmap up to the very top (marked) and use it here too?

> My local testing seems to be saving 100-200MB peak on a run like dm --config
> serialize-8888  --src gm skp

Done.

[mtklein, 2015-02-23 18:21:29]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-02-23 18:21:29]

lgtm

[commit-bot: I haz the power, 2015-02-23 18:22:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/943383002/60001

[commit-bot: I haz the power, 2015-02-23 18:28:06]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/77d366d72a6ae83fb0abcb2ec7e2d692fef2e923

[hal.canary, 2015-02-23 18:42:29]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/947103005/ by halcanary@google.com.

The reason for reverting is: crashing dm

Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug

u gm addarc
(1431MB   932) 169ms	gpu gm aarectmodes
(1431MB   931) 38.6ms	gpu gm aaclip
(1431MB   930) 474ms	gpu skp desk_amazon.skp
(1431MB   929) 615ms	gpu skp desk_baidu.skp
(1431MB   928) 600ms	gpu skp desk_blogger.skp
Signal 11:
_sigtramp (+0x1a)
compute_yuv_size(jpeg_decompress_struct const&, int, SizeType) (+0x30)
update_components_sizes(jpeg_decompress_struct const&, SkTSize<int>*, SizeType)
(+0x46)
SkJPEGImageDecoder::onDecodeYUV8Planes(SkStream*, SkTSize<int>*, void**,
unsigned long*, SkYUVColorSpace*) (+0x239)
SkImageDecoder::decodeYUV8Planes(SkStream*, SkTSize<int>*, void**, unsigned
long*, SkYUVColorSpace*) (+0x64)
SkImageDecoderGenerator::onGetYUV8Planes(SkTSize<int>*, void**, unsigned long*,
SkYUVColorSpace*) (+0x9f)
SkImageGenerator::getYUV8Planes(SkTSize<int>*, void**, unsigned long*,
SkYUVColorSpace*) (+0x3b7)
SkDiscardablePixelRef::onGetYUV8Planes(SkTSize<int>*, void**, unsigned long*,
SkYUVColorSpace*) (+0x3c)
SkPixelRef::getYUV8Planes(SkTSize<int>*, void**, unsigned long*,
SkYUVColorSpace*) (+0x55)
load_yuv_texture(GrContext*, GrUniqueKey const&, SkBitmap const&, GrSurfaceDesc
const&) (+0x24b)
create_unstretched_bitmap_texture(GrContext*, SkBitmap const&, GrUniqueKey
const&) (+0x3df)
create_bitmap_texture(GrContext*, SkBitmap const&, Stretch, GrUniqueKey const&,
GrUniqueKey const&) (+0x1ca)
GrRefCachedBitmapTexture(GrContext*, SkBitmap const&, GrTextureParams const*)
(+0x368)
AutoBitmapTexture::set(GrContext*, SkBitmap const&, GrTextureParams const*)
(+0x87)
AutoBitmapTexture::AutoBitmapTexture(GrContext*, SkBitmap const&,
GrTextureParams const*, GrTexture**) (+0xe0)
AutoBitmapTexture::AutoBitmapTexture(GrContext*, SkBitmap const&,
GrTextureParams const*, GrTexture**) (+0x35)
SkGpuDevice::internalDrawBitmap(SkBitmap const&, SkMatrix const&, SkRect const&,
GrTextureParams const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags, bool,
bool) (+0x118)
SkGpuDevice::drawBitmapCommon(SkDraw const&, SkBitmap const&, SkRect const*,
SkSize const*, SkPaint const&, SkCanvas::DrawBitmapRectFlags) (+0xa84)
SkGpuDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*,
SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags) (+0x2bb)
SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&,
SkPaint const*, SkCanvas::DrawBitmapRectFlags) (+0x2a9)
SkCanvas::onDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&,
SkPaint const*, SkCanvas::DrawBitmapRectFlags) (+0x118)
SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*, SkRect const&,
SkPaint const*, SkCanvas::DrawBitmapRectFlags) (+0x60)
void
SkRecords::Draw::draw<SkRecords::DrawBitmapRectToRect>(SkRecords::DrawBitmapRectToRect
const&) (+0x8a)
void
SkRecords::Draw::operator()<SkRecords::DrawBitmapRectToRect>(SkRecords::DrawBitmapRectToRect
const&) (+0x1d)
void SkRecord::Record::visit<void, SkRecords::Draw>(SkRecord::Type8,
SkRecords::Draw&) const (+0x298)
void SkRecord::visit<void, SkRecords::Draw>(unsigned int, SkRecords::Draw&)
const (+0xbc)
SkRecordDraw(SkRecord const&, SkCanvas*, SkPicture const* const*, SkDrawable*
const*, int, SkBBoxHierarchy const*, SkPicture::AbortCallback*) (+0x2eb)
SkPicture::playback(SkCanvas*, SkPicture::AbortCallback*) const (+0x186)
SkCanvas::onDrawPicture(SkPicture const*, SkMatrix const*, SkPaint const*)
(+0xe0)
SkCanvas::drawPicture(SkPicture const*) (+0x11b)
DM::SKPSrc::draw(SkCanvas*) const (+0x25b)
DM::GPUSink::draw(DM::Src const&, SkBitmap*, SkWStream*, SkString*) const
(+0x21d)
Task::Run(Task*) (+0x1de)
run_enclave(SkTArray<Task, false>*) (+0x49)
run_enclave_and_gpu_tests(SkTArray<Task, false>*) (+0x15)
(anonymous namespace)::ThreadPool::Wait(int*) (+0x14b)
SkTaskGroup::wait() (+0x15)
dm_main() (+0x624)
main (+0x27)

.

[hal.canary, 2015-02-23 19:25:06]

New patchsets have been uploaded after l-g-t-m from mtklein@google.com

[hal.canary, 2015-03-17 17:02:17]

Patchset #6 (id:100001) has been deleted