Issue 943343004: Revert "Implement pthread_rwlock functions for NaCl newlib."

Issue 943343004: Revert "Implement pthread_rwlock functions for NaCl newlib." (Closed)

Created:
5 years, 10 months ago by Sam Clegg

Modified:
5 years, 10 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com, jvoung (off chromium), JF

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Revert "Implement pthread_rwlock functions for NaCl newlib." This reverts commit 9e3dac822315394238e650282a43fb4aacdbc6c9. The implementation contains a bug in the unlock hanlding when a reader calls unlock on a lock that is only being waited on by other readers. This case was not covered by the tests and was noticed first in the untrusted PNaCl translator tests (the llvm build will apparently use rwlock if found). BUG= https://code.google.com/p/nativeclient/issues/detail?id=4105 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3960 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/26f5754ba5af5b6fc94c998555719753824700fe

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -658 lines)			Patch
M	src/untrusted/pthread/nacl.scons	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/untrusted/pthread/nc_rwlock.c	View	1 chunk	+0 lines, -293 lines	0 comments	Download
M	src/untrusted/pthread/nc_thread.c	View	6 chunks	+16 lines, -5 lines	0 comments	Download
M	src/untrusted/pthread/pthread.h	View	5 chunks	+1 line, -50 lines	0 comments	Download
M	src/untrusted/pthread/pthread.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/untrusted/pthread/pthread_internal.h	View	2 chunks	+1 line, -14 lines	0 comments	Download
M	src/untrusted/pthread/pthread_types.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/threads/nacl.scons	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	tests/threads/rwlock_test.c	View	1 chunk	+0 lines, -279 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943343004/1

5 years, 10 months ago (2015-02-23 23:03:07 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 01:26:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/26f5754ba...