Issue 943333006: MidiManagerUsb should be able to accept multiple devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943333006: MidiManagerUsb should be able to accept multiple devices. (Closed)

Created:
5 years, 10 months ago by yhirano

Modified:
5 years, 10 months ago

Reviewers:
Takashi Toyoshima

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

MidiManagerUsb should be able to accept multiple devices. This CL fixes MidiManagerUsb's bug which prevented the manager from listening input events coming from multiple MIDI devices. BUG=None R=toyoshim@chromium.org Committed: https://crrev.com/34d00754b9a79bcec3099737c851a07c3cfaa7fd Cr-Commit-Position: refs/heads/master@{#318048}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -2 lines)			Patch
	M	media/midi/midi_manager_usb.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
	M	media/midi/midi_manager_usb_unittest.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943333006/1

5 years, 10 months ago (2015-02-25 15:18:40 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 15:33:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/34d00754b9a79bcec3099737c851a07c3cfaa7fd
Cr-Commit-Position: refs/heads/master@{#318048}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages