Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 943333004: Remove SkFontHost includes and friends. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkFontHost includes and friends. SkFontHost no longer exists as a class, so remove the includes and stop making it a friend. Committed: https://skia.googlesource.com/skia/+/7be2eb89cc85fc9fc05814957d152f3d20613657

Patch Set 1 #

Patch Set 2 : Fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M include/core/SkAdvancedTypefaceMetrics.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkTypeface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontConfigTypeface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_linux.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
bungeman-skia
I started this because SkTypeface is quite friendly, but it turns out that no one ...
5 years, 10 months ago (2015-02-23 16:13:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943333004/20001
5 years, 10 months ago (2015-02-23 16:13:50 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-23 16:13:50 UTC) #5
commit-bot: I haz the power
Presubmit check for 943333004-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 10 months ago (2015-02-23 16:13:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943333004/20001
5 years, 10 months ago (2015-02-23 16:15:49 UTC) #9
reed1
lgtm
5 years, 10 months ago (2015-02-23 16:19:20 UTC) #10
commit-bot: I haz the power
This issue passed the CQ. To commit it, remove "COMMIT=false" from the description and try ...
5 years, 10 months ago (2015-02-23 16:21:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943333004/20001
5 years, 10 months ago (2015-02-23 16:24:53 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 16:25:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7be2eb89cc85fc9fc05814957d152f3d20613657

Powered by Google App Engine
This is Rietveld 408576698