Issue 943333003: Remove HTMLMediaElement::hasMediaControls()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943333003: Remove HTMLMediaElement::hasMediaControls() (Closed)

Created:
5 years, 10 months ago by philipj_slow

Modified:
5 years, 10 months ago

Reviewers:
fs

CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove HTMLMediaElement::hasMediaControls() It is consistently used as a null check for mediaControls() and is no more efficient, so keep only mediaControls(). toMediaControls() includes an equivalent null check and ASSERT_WITH_SECURITY_IMPLICATION. BUG=448795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190711

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -33 lines)			Patch
	M	Source/core/html/HTMLMediaElement.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	Source/core/html/HTMLMediaElement.cpp	View		19 chunks	+25 lines, -32 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

philipj_slow

On 2015/02/23 15:27:23, fs wrote: > lgtm > > Description nit: equivlant Fixed, thanks!

5 years, 10 months ago (2015-02-24 01:55:23 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943333003/1

5 years, 10 months ago (2015-02-24 01:56:28 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 02:01:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190711

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages