Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 943333003: Remove HTMLMediaElement::hasMediaControls() (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
fs
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove HTMLMediaElement::hasMediaControls() It is consistently used as a null check for mediaControls() and is no more efficient, so keep only mediaControls(). toMediaControls() includes an equivalent null check and ASSERT_WITH_SECURITY_IMPLICATION. BUG=448795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M Source/core/html/HTMLMediaElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 19 chunks +25 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 10 months ago (2015-02-23 10:22:09 UTC) #2
fs
lgtm Description nit: equivlant
5 years, 10 months ago (2015-02-23 15:27:23 UTC) #3
philipj_slow
On 2015/02/23 15:27:23, fs wrote: > lgtm > > Description nit: equivlant Fixed, thanks!
5 years, 10 months ago (2015-02-24 01:55:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943333003/1
5 years, 10 months ago (2015-02-24 01:56:28 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 02:01:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190711

Powered by Google App Engine
This is Rietveld 408576698