Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 943303002: Simplify form validation handling (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add a test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFieldSetElement.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormControlElement.h
diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h
index be1f58dfd62ab17e7b9605a3855659ceee350f9c..5b2921cfe3f5c3bc1ea45ae7f78de4a0677f6d8a 100644
--- a/Source/core/html/HTMLFormControlElement.h
+++ b/Source/core/html/HTMLFormControlElement.h
@@ -34,7 +34,6 @@ class HTMLFormElement;
class ValidationMessageClient;
enum CheckValidityEventBehavior { CheckValidityDispatchNoEvent, CheckValidityDispatchInvalidEvent };
-enum ValidityRecalcReason { ElementAddition, ElementRemoval, ElementModification };
// HTMLFormControlElement is the default implementation of FormAssociatedElement,
// and form-associated element implementations should use HTMLFormControlElement
@@ -170,9 +169,7 @@ private:
ValidationMessageClient* validationMessageClient() const;
// Requests validity recalc for the form owner, if one exists.
- // In case of removal, isValid specifies element validity upon removal.
- // In case of addition and modification, it specifies new validity.
- void formOwnerSetNeedsValidityCheck(ValidityRecalcReason, bool isValid);
+ void formOwnerSetNeedsValidityCheck();
// Requests validity recalc for all ancestor fieldsets, if exist.
void fieldSetAncestorsSetNeedsValidityCheck(Node*);
@@ -194,8 +191,8 @@ private:
mutable bool m_willValidate : 1;
// Cache of valid().
- // But "candidate for constraint validation" doesn't affect m_isValid.
bool m_isValid : 1;
+ bool m_validityIsDirty : 1;
bool m_wasChangedSinceLastFormControlChangeEvent : 1;
bool m_wasFocusedByMouse : 1;
« no previous file with comments | « Source/core/html/HTMLFieldSetElement.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698