Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 943293002: [Oilpan] Set stack limit using estimated sizes (Re-land) (Closed)

Created:
5 years, 10 months ago by peria
Modified:
5 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set the stack limit size based on estimated sizes. To check if the stack memory has enough room for recursive calls, we tried to allocate a large object and assumed the size. This CL estimate the real thread stack limit using APIs. On some platforms where such APIs do not work correctly, we set the limit using the old algorithm. --- This CL is re-land of https://codereview.chromium.org/910663002/ and https://codereview.chromium.org/927213002/. Test was changed in another CL https://codereview.chromium.org/946483002/ BUG=420515, 457982 R=kouhei Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190636

Patch Set 1 #

Patch Set 2 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M Source/platform/heap/StackFrameDepth.cpp View 1 3 chunks +42 lines, -6 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
peria
PTL
5 years, 10 months ago (2015-02-23 03:49:54 UTC) #1
peria
PTL
5 years, 10 months ago (2015-02-23 03:50:12 UTC) #3
haraken
LGTM
5 years, 10 months ago (2015-02-23 03:57:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943293002/20001
5 years, 10 months ago (2015-02-23 03:58:17 UTC) #6
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-23 04:10:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190636
5 years, 10 months ago (2015-02-23 05:15:11 UTC) #8
hiroshige
Hi, I'm suspecting this CL causes browser test failures. See https://crbug.com/460868 for details.
5 years, 10 months ago (2015-02-23 10:09:43 UTC) #9
hiroshige
5 years, 10 months ago (2015-02-23 11:13:08 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/953453003/ by hiroshige@chromium.org.

The reason for reverting is: Speculatively reverted due to failures in browser
test ExtensionPageCaptureApiTest.SaveAsMHTML.

BUG=460868.

Powered by Google App Engine
This is Rietveld 408576698