Issue 943273004: Fold BIT_NOT and NEGATE during constant propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943273004: Fold BIT_NOT and NEGATE during constant propagation. (Closed)

Created:
5 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 10 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Fold BIT_NOT and NEGATE during constant propagation. Convert (a & 2^n) == 2^n into TestSmi instruction. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43957

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -29 lines)			Patch
M	runtime/vm/constant_propagator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/constant_propagator.cc	View		1 chunk	+18 lines, -9 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		4 chunks	+79 lines, -13 lines	0 comments	Download
M	tests/language/vm/optimized_testsmi_test.dart	View	1	2 chunks	+33 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

LGTM if you add test coverage for the new pattern.

5 years, 10 months ago (2015-02-23 12:51:50 UTC) #2

Vyacheslav Egorov (Google)

5 years, 10 months ago (2015-02-23 14:53:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43957 (presubmit successful).