Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2606)

Unified Diff: Source/modules/webmidi/MIDIAccess.cpp

Issue 943173002: Web MIDI: dispatch MIDIConnectionEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/MIDIAccess.cpp
diff --git a/Source/modules/webmidi/MIDIAccess.cpp b/Source/modules/webmidi/MIDIAccess.cpp
index c9ea88f5b25d9fc3b31c8a6ff7196dd62e51d889..f50036b5ec1d7b3493e1d10b6d7a80fe4c4b0232 100644
--- a/Source/modules/webmidi/MIDIAccess.cpp
+++ b/Source/modules/webmidi/MIDIAccess.cpp
@@ -107,6 +107,8 @@ void MIDIAccess::didAddInputPort(const String& id, const String& manufacturer, c
{
ASSERT(isMainThread());
m_inputs.append(MIDIInput::create(this, id, manufacturer, name, version, isActive));
+ // FIXME: Pass MIDIPort.
+ dispatchEvent(MIDIConnectionEvent::create());
}
void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive)
@@ -114,20 +116,30 @@ void MIDIAccess::didAddOutputPort(const String& id, const String& manufacturer,
ASSERT(isMainThread());
unsigned portIndex = m_outputs.size();
m_outputs.append(MIDIOutput::create(this, portIndex, id, manufacturer, name, version, isActive));
+ // FIXME: Pass MIDIPort.
+ dispatchEvent(MIDIConnectionEvent::create());
}
void MIDIAccess::didSetInputPortState(unsigned portIndex, bool isActive)
{
ASSERT(isMainThread());
- if (portIndex < m_inputs.size())
- m_inputs[portIndex]->setActiveState(isActive);
+ if (portIndex >= m_inputs.size())
+ return;
+
+ m_inputs[portIndex]->setActiveState(isActive);
+ // FIXME: Pass MIDIPort.
+ dispatchEvent(MIDIConnectionEvent::create());
}
void MIDIAccess::didSetOutputPortState(unsigned portIndex, bool isActive)
{
ASSERT(isMainThread());
- if (portIndex < m_outputs.size())
- m_outputs[portIndex]->setActiveState(isActive);
+ if (portIndex >= m_outputs.size())
+ return;
+
+ m_outputs[portIndex]->setActiveState(isActive);
+ // FIXME: Pass MIDIPort.
+ dispatchEvent(MIDIConnectionEvent::create());
}
void MIDIAccess::didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp)

Powered by Google App Engine
This is Rietveld 408576698