Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 943173002: Web MIDI: dispatch MIDIConnectionEvent (Closed)

Created:
5 years, 10 months ago by Takashi Toyoshima
Modified:
5 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web MIDI: dispatch MIDIConnectionEvent In the latest editor's draft spec, MIDIAccess has only one EventHandler onstatechange that is integrated thing of onconnect and ondisconnect. Also, ondisconnect of MIDIPort is also renamed to onstatechange. See the latest editor]s draft spec: - http://webaudio.github.io/web-midi-api/#midiaccess-interface - http://webaudio.github.io/web-midi-api/#idl-def-MIDIPort This patch update these EventHandler attributes, and also add implementation to dispatch these events. BUG=279097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190653

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -44 lines) Patch
M Source/modules/webmidi/MIDIAccess.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 1 1 chunk +16 lines, -6 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.h View 1 2 chunks +21 lines, -5 lines 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.cpp View 1 2 chunks +0 lines, -25 lines 0 comments Download
M Source/modules/webmidi/MIDIMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIMessageEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Takashi Toyoshima
Kouhei, I have some questions on this CL. Please allow me to have some offline ...
5 years, 10 months ago (2015-02-21 17:17:56 UTC) #2
kouhei (in TOK)
https://codereview.chromium.org/943173002/diff/1/Source/modules/webmidi/MIDIConnectionEvent.h File Source/modules/webmidi/MIDIConnectionEvent.h (right): https://codereview.chromium.org/943173002/diff/1/Source/modules/webmidi/MIDIConnectionEvent.h#newcode63 Source/modules/webmidi/MIDIConnectionEvent.h:63: DEFINE_INLINE_VIRTUAL_TRACE() DECLARE_VIRTUAL_TRACE is recommended over DEFINE_INLINE_VIRTUAL_TRACE where the class ...
5 years, 10 months ago (2015-02-23 01:40:41 UTC) #3
Takashi Toyoshima
thanks. now it works fine. please take another look. https://codereview.chromium.org/943173002/diff/1/Source/modules/webmidi/MIDIConnectionEvent.h File Source/modules/webmidi/MIDIConnectionEvent.h (right): https://codereview.chromium.org/943173002/diff/1/Source/modules/webmidi/MIDIConnectionEvent.h#newcode63 Source/modules/webmidi/MIDIConnectionEvent.h:63: ...
5 years, 10 months ago (2015-02-23 11:15:35 UTC) #4
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-23 11:17:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943173002/20001
5 years, 10 months ago (2015-02-23 11:18:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 13:08:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190653

Powered by Google App Engine
This is Rietveld 408576698